From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH 04/16] tmem: cleanup: rm unneeded parameters
 from put path
Date: Tue, 26 Nov 2013 16:22:10 +0800
Message-ID: <52945A32.8060000@oracle.com>
References: <1384937185-24749-1-git-send-email-bob.liu@oracle.com>
	<1384937185-24749-4-git-send-email-bob.liu@oracle.com>
	<20131122175445.GB8120@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <bob.liu@oracle.com>) id 1VlDuY-0008IQ-Lx
	for xen-devel@lists.xenproject.org; Tue, 26 Nov 2013 08:22:22 +0000
In-Reply-To: <20131122175445.GB8120@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, Bob Liu <lliubbo@gmail.com>, keir@xen.org, ian.campbell@citrix.com, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org


On 11/23/2013 01:54 AM, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 20, 2013 at 04:46:13PM +0800, Bob Liu wrote:
>> tmem only takes a page as unit, so parameters tmem_offset, pfn_offset and len
>> are meanless, this patch remove those parameters from do_tmem_put() related path
>       ^^^^^^^^                   ^-s
> 
> 
> Not exactly right. They were used by TMEM_WRITE and TMEM_READ, but your
> other patch "tmem: cleanup: rm unused tmem_op" removed them.
> 
> Looking a bit on Google I see this thread:
> 
> http://marc.info/?l=xen-devel&m=136975816209598
> 
> 
> which implies that the Windows GPL driver is using it? Did you
> check its code? (See http://xenbits.xen.org/ext/win-pvdrivers/)
> 

Okay, I'll check the Windows drivers.

> If it is not in the code, can you also CC James Harper on it so
> he knows not use those ops?
>

Sure.

Thanks,
-Bob