From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Coverity issues from 27/11/2013 Date: Wed, 27 Nov 2013 13:03:33 +0000 Message-ID: <5295EDA5.4060509@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Wilk , Bob Liu Cc: Xen-devel List List-Id: xen-devel@lists.xenproject.org A very good Coverity run today. 30 issues fixed and only 2 introduced. The two introduced were not directly as a result of recent changes, but as a result of the tmem improvements. Coverity tags an issue with types and names, so refactored code gets new issues tagged against it. The two 'new' issues are both to do with: static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t clibuf, int off, char *tmembuf, int len) { copy_to_guest_offset(clibuf,off,tmembuf,len); } Which throws away important errors which should not be ignored. I guess this is more something which needs considering when doing functional improvements to the tmem code. ~Andrew