* Coverity issues from 27/11/2013
@ 2013-11-27 13:03 Andrew Cooper
2013-11-27 14:31 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2013-11-27 13:03 UTC (permalink / raw)
To: Konrad Wilk, Bob Liu; +Cc: Xen-devel List
A very good Coverity run today. 30 issues fixed and only 2 introduced.
The two introduced were not directly as a result of recent changes, but
as a result of the tmem improvements. Coverity tags an issue with types
and names, so refactored code gets new issues tagged against it.
The two 'new' issues are both to do with:
static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t clibuf,
int off,
char *tmembuf, int len)
{
copy_to_guest_offset(clibuf,off,tmembuf,len);
}
Which throws away important errors which should not be ignored.
I guess this is more something which needs considering when doing
functional improvements to the tmem code.
~Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Coverity issues from 27/11/2013
2013-11-27 13:03 Coverity issues from 27/11/2013 Andrew Cooper
@ 2013-11-27 14:31 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2013-11-27 14:31 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel List
On Wed, Nov 27, 2013 at 01:03:33PM +0000, Andrew Cooper wrote:
> A very good Coverity run today. 30 issues fixed and only 2 introduced.
Woot!
>
> The two introduced were not directly as a result of recent changes, but
> as a result of the tmem improvements. Coverity tags an issue with types
> and names, so refactored code gets new issues tagged against it.
>
>
> The two 'new' issues are both to do with:
>
> static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t clibuf,
>
> int off,
> char *tmembuf, int len)
> {
> copy_to_guest_offset(clibuf,off,tmembuf,len);
> }
>
> Which throws away important errors which should not be ignored.
That had been there before (this CID).
>
> I guess this is more something which needs considering when doing
> functional improvements to the tmem code.
One of the patches that Bob posted fixes this (by eliminating the
user of this inline function). I am waiting for those to be respun.
And then I will post an GIT PULL to pull them in.
It will be after Thanksgiving.
>
> ~Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-27 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-27 13:03 Coverity issues from 27/11/2013 Andrew Cooper
2013-11-27 14:31 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).