From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 2/2] use return value of domain_adjust_tot_pages() where feasible Date: Wed, 27 Nov 2013 14:44:37 +0000 Message-ID: <52960555.2040803@eu.citrix.com> References: <5295B64E0200007800107636@nat28.tlf.novell.com> <5295BAD0020000780010765E@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VlgM8-0008WH-4C for xen-devel@lists.xenproject.org; Wed, 27 Nov 2013 14:44:44 +0000 In-Reply-To: <5295BAD0020000780010765E@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Andrew Cooper , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 11/27/2013 08:26 AM, Jan Beulich wrote: > This is generally cheaper than re-reading ->tot_pages. > > While doing so I also noticed an improper use (lacking error handling) > of get_domain() as well as lacks of ->is_dying checks in the memory > sharing code, which the patch fixes at once. In the course of doing > this I further noticed other error paths there pointlessly calling > put_page() et al with ->page_alloc_lock still held, which is also being > reversed. Thus hiding two very important changes underneath a summary that looks completely unimportant. If this patch only did as the title suggests, I would question whether it should be included for 4.4, since it seems to have little benefit. Are the other two changes bug fixes? In any case, the summary should indicate to someone just browsing through what important changes might be inside. -George