From: George Dunlap <george.dunlap@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel List <xen-devel@lists.xen.org>,
Dario Faggioli <dario.faggioli@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>
Subject: Re: Xen-4.3 and -unstable regression from changeset "numa-sched: leave node-affinity alone if not in 'auto' mode"
Date: Thu, 28 Nov 2013 15:09:49 +0000 [thread overview]
Message-ID: <52975CBD.8010408@eu.citrix.com> (raw)
In-Reply-To: <529737AD.7070708@citrix.com>
On 11/28/2013 12:31 PM, Andrew Cooper wrote:
> Hello,
>
> I have recently positivly identified
> b54a623efbcf5bff25c55117add1b4427b4e2f1b as causing a boot failure.
>
> Serial log is attached. The crash is completely deterministic, and is
> from an IBM xSeries 3530 M4 server.
>
> Given the crash and bad patch, I suspect it is more to do with the
> NUMA/memory layout than the specifics of the server.
>
> Dario: Being your patch, do you have any ideas?
Do you have a xen-syms you can use to find out what line the crash
happened at?
Dom0 should have auto_node_affinity set at this point; so before this
patch you'd have:
nodemask = NODEMASK_MASK_NONE;
[set nodes in nodemask from cpumask]
d->node_affinity=nodemask
After, you have:
nodes_clear(d->node_affinity)
[set nodes in d->node_affinity from cpumask]
Everything looks like it should be the same.
Can you try just reverting what's in the positive side of the if()?
I.e., adding back in nodemask=NODE_MASK_NONE at the top, and the
nodemask copying, and see what happens?
-George
next prev parent reply other threads:[~2013-11-28 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 12:31 Xen-4.3 and -unstable regression from changeset "numa-sched: leave node-affinity alone if not in 'auto' mode" Andrew Cooper
2013-11-28 13:05 ` Dario Faggioli
2013-11-28 15:09 ` George Dunlap [this message]
2013-11-28 15:14 ` Dario Faggioli
2013-11-28 15:16 ` Andrew Cooper
2013-11-28 21:17 ` Andrew Cooper
2013-11-28 23:30 ` George Dunlap
2013-11-29 10:51 ` Ian Campbell
2013-11-29 11:04 ` Andrew Cooper
2013-12-02 14:01 ` Andrew Cooper
2013-12-02 14:36 ` Jan Beulich
2013-12-03 19:53 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52975CBD.8010408@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).