From: David Vrabel <david.vrabel@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH net-next] xen-netback: improve guest-receive-side flow control
Date: Mon, 2 Dec 2013 11:52:18 +0000 [thread overview]
Message-ID: <529C7472.60303@citrix.com> (raw)
In-Reply-To: <1385644272-29728-1-git-send-email-paul.durrant@citrix.com>
On 28/11/13 13:11, Paul Durrant wrote:
> The flow control code relies on a double pass of tke skb, firstly to count
> the number of ring slots needed to supply sufficient grant references, and
> another to actually consume those references and build the grant copy
> operations. It transpires that, in some scenarios, the initial count and the
> number of references consumed differs and, after this happens a number of
> times, flow control is completely broken.
Can you describe in more detail the cases where it gets it wrong?
> -unsigned int xenvif_count_skb_slots(struct xenvif *vif, struct sk_buff *skb)
Any patch that gets rid of this gets my vote (provided it works!).
Can you list all the guest frontends that you've tested this with?
David
next prev parent reply other threads:[~2013-12-02 11:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 13:11 [PATCH net-next] xen-netback: improve guest-receive-side flow control Paul Durrant
2013-11-28 15:51 ` Wei Liu
2013-11-28 16:05 ` Paul Durrant
2013-11-28 16:27 ` Wei Liu
2013-11-28 16:33 ` Paul Durrant
2013-11-28 16:44 ` Wei Liu
2013-12-02 11:53 ` David Vrabel
2013-11-29 8:20 ` annie li
2013-11-29 10:03 ` Paul Durrant
2013-12-01 4:18 ` annie li
2013-12-02 10:52 ` Paul Durrant
2013-12-02 11:52 ` David Vrabel [this message]
2013-12-02 11:55 ` Paul Durrant
2013-12-02 11:59 ` David Vrabel
2013-12-02 12:01 ` Paul Durrant
2013-12-03 20:22 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C7472.60303@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).