From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [PATCH] xen: privcmd: do not return pages which we have failed to unmap Date: Wed, 4 Dec 2013 16:12:08 +0000 Message-ID: <529F5458.6020100@citrix.com> References: <1386172341-12110-1-git-send-email-ian.campbell@citrix.com> <529F5112.3020206@citrix.com> <1386173033.17466.99.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VoF3c-0002NQ-RT for xen-devel@lists.xenproject.org; Wed, 04 Dec 2013 16:12:12 +0000 In-Reply-To: <1386173033.17466.99.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 04/12/13 16:03, Ian Campbell wrote: > Subject: [PATCH] xen: privcmd: do not return pages which we have failed to > unmap > > This failure represents a hypervisor issue, but if it does occur then nothing > good can come of returning pages which still refer to a foreign owned page > into the general allocation pool. > > Instead we are forced to leak them. Log that we have done so. > > The potential for failure only exists for autotranslated guest (e.g. ARM and > x86 PVH). Reviewed-by: David Vrabel David