From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com,
time@xen.org, patches@linaro.org
Subject: Re: [PATCH 2/8] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c
Date: Thu, 05 Dec 2013 15:50:10 +0000 [thread overview]
Message-ID: <52A0A0B2.8090705@linaro.org> (raw)
In-Reply-To: <1386258476.20047.81.camel@kazak.uk.xensource.com>
On 12/05/2013 03:47 PM, Ian Campbell wrote:
> On Thu, 2013-12-05 at 15:42 +0000, Julien Grall wrote:
>> The function mfn_to_p2m_entry will be extended in a following patch to handle
>> p2m_type_t. It will break compilation because p2m_type_t is not defined
>> (interdependence between includes).
>> It's easier to move the function in arch/arm/p2m.c and it's not harmful as the
>> function is only used in this file.
>
> You forgot your S-o-b.
Oh, right:
Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
>
--
Julien Grall
next prev parent reply other threads:[~2013-12-05 15:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 15:42 [PATCH 0/8] xen/arm: Handle correctly foreign mapping Julien Grall
2013-12-05 15:42 ` [PATCH 1/8] DO NOT APPLY: xen/arm: Correctly support foreign page removing on ARM Julien Grall
2013-12-05 15:42 ` [PATCH 2/8] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c Julien Grall
2013-12-05 15:47 ` Ian Campbell
2013-12-05 15:50 ` Julien Grall [this message]
2013-12-05 15:42 ` [PATCH 3/8] xen/arm: Implement p2m_type_t as an enum Julien Grall
2013-12-05 15:51 ` Egger, Christoph
2013-12-05 15:56 ` Ian Campbell
2013-12-09 11:16 ` Egger, Christoph
2013-12-09 11:38 ` Ian Campbell
2013-12-05 15:52 ` Ian Campbell
2013-12-05 16:01 ` Julien Grall
2013-12-05 16:14 ` Ian Campbell
2013-12-05 16:28 ` Julien Grall
2013-12-05 16:38 ` Ian Campbell
2013-12-05 16:44 ` Julien Grall
2013-12-05 16:56 ` Ian Campbell
2013-12-05 21:26 ` Julien Grall
2013-12-05 16:07 ` Tim Deegan
2013-12-05 16:19 ` Ian Campbell
2013-12-05 16:31 ` Tim Deegan
2013-12-05 16:39 ` Ian Campbell
2013-12-05 17:24 ` Tim Deegan
2013-12-05 15:42 ` [PATCH 4/8] xen/arm: Store p2m type in each page of the guest Julien Grall
2013-12-05 15:55 ` Ian Campbell
2013-12-05 16:02 ` Ian Campbell
2013-12-05 16:07 ` Julien Grall
2013-12-05 15:42 ` [PATCH 5/8] xen/arm: p2m: Add p2m_get_entry Julien Grall
2013-12-05 16:07 ` Ian Campbell
2013-12-05 16:09 ` Tim Deegan
2013-12-05 15:42 ` [PATCH 6/8] xen/arm: Retrieve p2m type in get_page_from_gfn Julien Grall
2013-12-05 16:23 ` Ian Campbell
2013-12-05 16:45 ` Julien Grall
2013-12-09 2:36 ` Julien Grall
2013-12-09 9:57 ` Ian Campbell
2013-12-05 15:42 ` [PATCH 7/8] xen/arm: Set foreign page type to p2m_map_foreign Julien Grall
2013-12-05 16:34 ` Ian Campbell
2013-12-05 16:41 ` Julien Grall
2013-12-05 16:54 ` Ian Campbell
2013-12-05 17:39 ` Julien Grall
2013-12-05 17:49 ` Ian Campbell
2013-12-09 2:14 ` Julien Grall
2013-12-05 15:42 ` [PATCH 8/8] xen/arm: grant-table: Support read-only mapping Julien Grall
2013-12-05 16:36 ` Ian Campbell
2013-12-05 15:44 ` [PATCH 0/8] xen/arm: Handle correctly foreign mapping Julien Grall
2013-12-05 17:10 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A0A0B2.8090705@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=time@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).