From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 2/8] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c Date: Thu, 05 Dec 2013 15:50:10 +0000 Message-ID: <52A0A0B2.8090705@linaro.org> References: <1386258131-755-1-git-send-email-julien.grall@linaro.org> <1386258131-755-3-git-send-email-julien.grall@linaro.org> <1386258476.20047.81.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VobBu-0003qv-60 for xen-devel@lists.xenproject.org; Thu, 05 Dec 2013 15:50:14 +0000 Received: by mail-ea0-f178.google.com with SMTP id d10so11767247eaj.9 for ; Thu, 05 Dec 2013 07:50:12 -0800 (PST) In-Reply-To: <1386258476.20047.81.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, time@xen.org, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 12/05/2013 03:47 PM, Ian Campbell wrote: > On Thu, 2013-12-05 at 15:42 +0000, Julien Grall wrote: >> The function mfn_to_p2m_entry will be extended in a following patch to handle >> p2m_type_t. It will break compilation because p2m_type_t is not defined >> (interdependence between includes). >> It's easier to move the function in arch/arm/p2m.c and it's not harmful as the >> function is only used in this file. > > You forgot your S-o-b. Oh, right: Signed-off-by: Julien Grall > Acked-by: Ian Campbell > > -- Julien Grall