From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Egger, Christoph" Subject: Re: [PATCH 3/8] xen/arm: Implement p2m_type_t as an enum Date: Thu, 5 Dec 2013 16:51:14 +0100 Message-ID: <52A0A0F2.8010408@amazon.de> References: <1386258131-755-1-git-send-email-julien.grall@linaro.org> <1386258131-755-4-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VobDL-00043s-KO for xen-devel@lists.xenproject.org; Thu, 05 Dec 2013 15:51:43 +0000 In-Reply-To: <1386258131-755-4-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, ian.campbell@citrix.com, time@xen.org, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 05.12.13 16:42, Julien Grall wrote: > Until now, Xen doesn't know the type of the page (ram, foreign page, mmio,...). > Introduce p2m_type_t with basic types: > - p2m_invalid: Nothing is mapped here > - p2m_ram_rw: Normal read/write guest RAM > - p2m_ram_ro: Read-only guest RAM > - p2m_mmio_direct: Read/write mapping of device memory > - p2m_map_foreign: RAM page from foreign guest > > Signed-off-by: Julien Grall > --- > xen/include/asm-arm/p2m.h | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h > index f079f00..b24f94a 100644 > --- a/xen/include/asm-arm/p2m.h > +++ b/xen/include/asm-arm/p2m.h > @@ -20,6 +20,16 @@ struct p2m_domain { > uint8_t vmid; > }; > > +typedef enum { > + p2m_invalid = 0, /* Nothing mapped here */ > + p2m_ram_rw = 1, /* Normal read/write guest RAM */ > + p2m_ram_ro = 2, /* Read-only; writes are silently dropped */ > + p2m_mmio_direct = 3, /* Read/write mapping of genuine MMIO area */ > + p2m_map_foreign = 4, /* Ram pages from foreign domain */ > +} p2m_type_t; > + > +#define p2m_is_foreign(_t) ((_t) == p2m_map_foreign) > + Is it possible to merge p2m_type_t with x86 and move into common code? Christoph > /* Initialise vmid allocator */ > void p2m_vmid_allocator_init(void); > > @@ -72,7 +82,6 @@ p2m_pod_decrease_reservation(struct domain *d, > unsigned int order); > > /* Look up a GFN and take a reference count on the backing page. */ > -typedef int p2m_type_t; > typedef unsigned int p2m_query_t; > #define P2M_ALLOC (1u<<0) /* Populate PoD and paged-out entries */ > #define P2M_UNSHARE (1u<<1) /* Break CoW sharing */ > @@ -110,8 +119,6 @@ static inline int get_page_and_type(struct page_info *page, > return rc; > } > > -#define p2m_is_foreign(_t) (0) > - > #endif /* _XEN_P2M_H */ > > /* >