From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Subject: Re: [PATCH V7] ns16550: Add support for UART present in
 Broadcom TruManage capable NetXtreme chips
Date: Thu, 5 Dec 2013 16:36:50 -0600
Message-ID: <52A10002.70505@amd.com>
References: <1386088803-2238-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
	<529E18E402000078001098EC@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Aravind.Gopalakrishnan@amd.com>) id 1VohXX-0005qj-KT
	for xen-devel@lists.xenproject.org; Thu, 05 Dec 2013 22:36:59 +0000
In-Reply-To: <529E18E402000078001098EC@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Thomas Lendacky <Thomas.Lendacky@amd.com>, andrew.cooper3@citrix.com, Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>, sherry.hurwitz@amd.com, xen-devel <xen-devel@lists.xenproject.org>, shurd@broadcom.com
List-Id: xen-devel@lists.xenproject.org

On 12/3/2013 10:46 AM, Jan Beulich wrote:
>>>> On 03.12.13 at 17:40, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com> wrote:
>> @@ -434,7 +477,22 @@ static void __init ns16550_endboot(struct serial_port *port)
>>       struct ns16550 *uart = port->uart;
>>   
>>       if ( uart->remapped_io_base )
>> +    {
>> +        if ( uart->enable_ro ) {
>> +            if ( rangeset_add_range(mmio_ro_ranges,
>> +                                    uart->io_base,
>> +                                    uart->io_base + uart->io_size - 1) )
>> +                printk(XENLOG_INFO "Error while adding MMIO range of device to mmio_ro_ranges\n");
>> +
>> +            if ( pci_ro_device(0, uart->ps_bdf[0],
>> +                               PCI_DEVFN(uart->ps_bdf[1], uart->ps_bdf[2])) )
> You didn't really fix what you said you fixed. Quoting from my
> reply to v6:

Ok, moved pci_ro_device also to ns16550_init_postirq now so that I do 
the hiding in one place..

>>> But, more importantly, did you overlook the use of pci_hide_device()
>>> in ns16550_init_postirq(): The hiding should be done in one place.
>>> And with pci_ro_device() implicitly hiding the device, you should
>>> probably make sure you call just one of the two.
>> +                printk(XENLOG_INFO "Could not mark config space of 0:%02x:%02x.%u read-only.\n",
>> +                                    uart->ps_bdf[0], uart->ps_bdf[1],
>> +                                    uart->ps_bdf[2]);
> The leading 0: is pretty pointless - an absent segment/domain
> identifier implies it being zero.
>
>
Fixed this. Sending out changes in V8.

-Aravind.