From: Bob Liu <bob.liu@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, Bob Liu <lliubbo@gmail.com>,
keir@xen.org, ian.campbell@citrix.com, JBeulich@suse.com
Subject: Re: [PATCH v2 13/16] tmem: cleanup: drop useless functions from head file
Date: Fri, 06 Dec 2013 14:53:29 +0800 [thread overview]
Message-ID: <52A17469.907@oracle.com> (raw)
In-Reply-To: <529DB34F.4000906@citrix.com>
On 12/03/2013 06:32 PM, Andrew Cooper wrote:
> On 03/12/13 02:19, Bob Liu wrote:
>> They are several one line functions in tmem_xen.h which are useless, this patch
>> embeded them into tmem.c directly.
>>
>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>> ---
>> xen/common/tmem.c | 22 +++++++++++-----------
>> xen/include/xen/tmem_xen.h | 27 ---------------------------
>> 2 files changed, 11 insertions(+), 38 deletions(-)
>>
>> diff --git a/xen/common/tmem.c b/xen/common/tmem.c
>> index abc9053..bdadb6e 100644
>> --- a/xen/common/tmem.c
>> +++ b/xen/common/tmem.c
>> @@ -1209,7 +1209,7 @@ obj_unlock:
>>
>> static int tmem_evict(void)
>> {
>> - struct client *client = tmem_client_from_current();
>> + struct client *client = (struct client *)current->domain->tmem;
>
> domain->tmem is currently a void pointer. It does not need casting.
>
> But as said before, domain->tmem should be turned from a void pointer to
> a client pointer.
>
Okay, I'll do that.
And I'll rename domain->tmem to domain->tmem_client to make it more
straightforward.
Thanks,
-Bob
next prev parent reply other threads:[~2013-12-06 6:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 2:19 [PATCH v2 00/16] tmem: continue to cleanup tmem Bob Liu
2013-12-03 2:19 ` [PATCH v2 01/16] tmem: fix public head file Bob Liu
2013-12-06 10:03 ` Jan Beulich
2013-12-06 14:36 ` Konrad Rzeszutek Wilk
2013-12-03 2:19 ` [PATCH v2 02/16] tmem: cleanup: drop unused sub command Bob Liu
2013-12-03 2:19 ` [PATCH v2 03/16] tmem: cleanup: drop some debug code Bob Liu
2013-12-03 2:19 ` [PATCH v2 04/16] tmem: cleanup: drop useless function 'tmem_copy_page' Bob Liu
2013-12-03 2:19 ` [PATCH v2 05/16] tmem: cleanup: drop useless parameters from put/get page Bob Liu
2013-12-03 2:19 ` [PATCH v2 06/16] tmem: cleanup: reorg function do_tmem_put() Bob Liu
2013-12-03 2:19 ` [PATCH v2 07/16] tmem: drop unneeded is_ephemeral() and is_private() Bob Liu
2013-12-03 2:19 ` [PATCH v2 08/16] tmem: cleanup: rm useless EXPORT/FORWARD define Bob Liu
2013-12-03 2:19 ` [PATCH v2 09/16] tmem: cleanup: drop runtime statistics Bob Liu
2013-12-03 2:19 ` [PATCH v2 10/16] tmem: cleanup: drop tmem_lock_all Bob Liu
2013-12-03 2:19 ` [PATCH v2 11/16] tmem: cleanup: refactor the alloc/free path Bob Liu
2013-12-03 2:19 ` [PATCH v2 12/16] tmem: cleanup: __tmem_alloc_page: drop unneed parameters Bob Liu
2013-12-03 2:19 ` [PATCH v2 13/16] tmem: cleanup: drop useless functions from head file Bob Liu
2013-12-03 10:32 ` Andrew Cooper
2013-12-06 6:53 ` Bob Liu [this message]
2013-12-03 2:19 ` [PATCH v2 14/16] tmem: refator function tmem_ensure_avail_pages() Bob Liu
2013-12-03 2:19 ` [PATCH v2 15/16] tmem: cleanup: rename tmem_relinquish_npages() Bob Liu
2013-12-03 2:19 ` [PATCH v2 16/16] tmem: cleanup: rm unused tmem_freeze_all() Bob Liu
2013-12-03 21:07 ` [PATCH v2 00/16] tmem: continue to cleanup tmem Konrad Rzeszutek Wilk
2013-12-03 21:50 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A17469.907@oracle.com \
--to=bob.liu@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=lliubbo@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).