From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bob Liu <bob.liu@oracle.com>
Subject: Re: [PATCH v2 13/16] tmem: cleanup: drop useless
 functions from head file
Date: Fri, 06 Dec 2013 14:53:29 +0800
Message-ID: <52A17469.907@oracle.com>
References: <1386037157-27261-1-git-send-email-bob.liu@oracle.com>
	<1386037157-27261-14-git-send-email-bob.liu@oracle.com>
	<529DB34F.4000906@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <bob.liu@oracle.com>) id 1VopIH-0007ab-UL
	for xen-devel@lists.xenproject.org; Fri, 06 Dec 2013 06:53:46 +0000
In-Reply-To: <529DB34F.4000906@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, Bob Liu <lliubbo@gmail.com>, keir@xen.org, ian.campbell@citrix.com, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org


On 12/03/2013 06:32 PM, Andrew Cooper wrote:
> On 03/12/13 02:19, Bob Liu wrote:
>> They are several one line functions in tmem_xen.h which are useless, this patch
>> embeded them into tmem.c directly.
>>
>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>> ---
>>  xen/common/tmem.c          |   22 +++++++++++-----------
>>  xen/include/xen/tmem_xen.h |   27 ---------------------------
>>  2 files changed, 11 insertions(+), 38 deletions(-)
>>
>> diff --git a/xen/common/tmem.c b/xen/common/tmem.c
>> index abc9053..bdadb6e 100644
>> --- a/xen/common/tmem.c
>> +++ b/xen/common/tmem.c
>> @@ -1209,7 +1209,7 @@ obj_unlock:
>>  
>>  static int tmem_evict(void)
>>  {
>> -    struct client *client = tmem_client_from_current();
>> +    struct client *client = (struct client *)current->domain->tmem;
> 
> domain->tmem is currently a void pointer.  It does not need casting.
> 
> But as said before, domain->tmem should be turned from a void pointer to
> a client pointer.
> 

Okay, I'll do that.
And I'll rename domain->tmem to domain->tmem_client to make it more
straightforward.

Thanks,
-Bob