From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com
Subject: Re: [PATCH 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ
Date: Fri, 06 Dec 2013 17:56:18 +0000 [thread overview]
Message-ID: <52A20FC2.6090505@linaro.org> (raw)
In-Reply-To: <1386350808-13648-6-git-send-email-stefano.stabellini@eu.citrix.com>
On 12/06/2013 05:26 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
[..]
> static void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n)
> {
> struct pending_irq *p;
> @@ -494,8 +509,10 @@ static int vgic_distr_mmio_write(struct vcpu *v, mmio_info_t *info)
> rank = vgic_irq_rank(v, 1, gicd_reg - GICD_ICENABLER);
> if ( rank == NULL) goto write_ignore;
> vgic_lock_rank(v, rank);
> + tr = rank->ienable;
> rank->ienable &= ~*r;
> vgic_unlock_rank(v, rank);
> + vgic_disable_irqs(v, (*r) & (~tr), gicd_reg - GICD_ICENABLER);
Why ~tr? We want to disable only enabled IRQ.
--
Julien Grall
next prev parent reply other threads:[~2013-12-06 17:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 17:26 [PATCH 0/6] interrupt handling fixes Stefano Stabellini
2013-12-06 17:26 ` [PATCH 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ Stefano Stabellini
2013-12-09 17:10 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 2/6] xen/arm: track the state of guest IRQs Stefano Stabellini
2013-12-09 17:38 ` Ian Campbell
2013-12-10 13:02 ` Stefano Stabellini
2013-12-06 17:26 ` [PATCH 3/6] xen/arm: do not add a second irq to the LRs if one is already present Stefano Stabellini
2013-12-06 17:26 ` [PATCH 4/6] xen/arm: implement gic_irq_enable and gic_irq_disable Stefano Stabellini
2013-12-06 18:29 ` Julien Grall
2013-12-09 17:42 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 5/6] xen/arm: Only enable physical IRQs when the guest asks Stefano Stabellini
2013-12-06 18:28 ` Julien Grall
2013-12-09 12:26 ` Stefano Stabellini
2013-12-09 17:44 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ Stefano Stabellini
2013-12-06 17:56 ` Julien Grall [this message]
2013-12-09 12:37 ` Stefano Stabellini
2013-12-09 12:48 ` Ian Campbell
2013-12-06 18:24 ` Julien Grall
2013-12-09 12:50 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A20FC2.6090505@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).