From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com
Subject: Re: [PATCH 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ
Date: Fri, 06 Dec 2013 18:24:09 +0000 [thread overview]
Message-ID: <52A21649.5080509@linaro.org> (raw)
In-Reply-To: <1386350808-13648-6-git-send-email-stefano.stabellini@eu.citrix.com>
On 12/06/2013 05:26 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> xen/arch/arm/vgic.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 5b533ea..9ac24b0 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -360,6 +360,21 @@ read_as_zero:
> return 1;
> }
>
> +static void vgic_disable_irqs(struct vcpu *v, uint32_t r, int n)
> +{
> + struct pending_irq *p;
> + unsigned int irq;
> + int i = 0;
> +
> + while ( (i = find_next_bit((const long unsigned int *) &r, 32, i)) < 32 ) {
> + irq = i + (32 * n);
> + p = irq_to_pending(v, irq);
> + if ( p->desc != NULL )
> + p->desc->handler->disable(p->desc);
Because of disable function will both both the GIC and irq_desc, you
will need to take:
- the GIC lock
- the IRQ desc lock
--
Julien Grall
next prev parent reply other threads:[~2013-12-06 18:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 17:26 [PATCH 0/6] interrupt handling fixes Stefano Stabellini
2013-12-06 17:26 ` [PATCH 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ Stefano Stabellini
2013-12-09 17:10 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 2/6] xen/arm: track the state of guest IRQs Stefano Stabellini
2013-12-09 17:38 ` Ian Campbell
2013-12-10 13:02 ` Stefano Stabellini
2013-12-06 17:26 ` [PATCH 3/6] xen/arm: do not add a second irq to the LRs if one is already present Stefano Stabellini
2013-12-06 17:26 ` [PATCH 4/6] xen/arm: implement gic_irq_enable and gic_irq_disable Stefano Stabellini
2013-12-06 18:29 ` Julien Grall
2013-12-09 17:42 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 5/6] xen/arm: Only enable physical IRQs when the guest asks Stefano Stabellini
2013-12-06 18:28 ` Julien Grall
2013-12-09 12:26 ` Stefano Stabellini
2013-12-09 17:44 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ Stefano Stabellini
2013-12-06 17:56 ` Julien Grall
2013-12-09 12:37 ` Stefano Stabellini
2013-12-09 12:48 ` Ian Campbell
2013-12-06 18:24 ` Julien Grall [this message]
2013-12-09 12:50 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A21649.5080509@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).