From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH 5/6] xen/arm: Only enable physical IRQs when
 the guest asks
Date: Fri, 06 Dec 2013 18:28:37 +0000
Message-ID: <52A21755.70906@linaro.org>
References: <alpine.DEB.2.02.1312061715200.7093@kaball.uk.xensource.com>
	<1386350808-13648-5-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1386350808-13648-5-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xen.org
Cc: Julien Grall <julien.grall@citrix.com>, ian.campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org



On 12/06/2013 05:26 PM, Stefano Stabellini wrote:
> From: Julien Grall <julien.grall@linaro.org>
>
> From: Julien Grall <julien.grall@linaro.org>
>
> Set/Unset IRQ_DISABLED from gic_irq_enable and gic_irq_disable.
> Enable IRQs when the guest requests it, not unconditionally at boot time.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> ---

[..]

> @@ -605,6 +603,8 @@ int __init setup_dt_irq(const struct dt_irq *irq, struct irqaction *new)
>
>       rc = __setup_irq(desc, irq->irq, new);
>
> +    desc->handler->startup(desc);
> +

You forgot to take the GIC lock here.

>       spin_unlock_irqrestore(&desc->lock, flags);
>
>       return rc;
> @@ -743,6 +743,7 @@ int gic_route_irq_to_guest(struct domain *d, const struct dt_irq *irq,
>       unsigned long flags;
>       int retval;
>       bool_t level;
> +    struct pending_irq *p;
>
>       action = xmalloc(struct irqaction);
>       if (!action)
> @@ -769,6 +770,10 @@ int gic_route_irq_to_guest(struct domain *d, const struct dt_irq *irq,
>           goto out;
>       }
>
> +    /* do not assume delivery to vcpu0 */

I would add TODO: in the comment.

-- 
Julien Grall