Re: [V6 PATCH 6.1/7] pvh dom0: Add and remove foreign pages

[Julien Grall <julien.grall@linaro.org>]

On 12/07/2013 02:34 AM, Mukesh Rathor wrote:
> New version of the patch with xenmem_rem_foreign_from_p2m() created:
>
> In this patch, a new function, xenmem_add_foreign_to_p2m(), is added
> to map pages from foreign guest into current dom0 for domU creation.
> Such pages are typed p2m_map_foreign. Another function
> xenmem_rem_foreign_from_p2m() is added to remove such pages. Note, in
> the remove path, we must release the refcount that was taken during
> the map phase.
>
> Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
> ---

[..]


> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
> index c660820..0c554a5 100644
> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -83,8 +83,6 @@ static inline struct page_info *get_page_from_gfn(
>       struct page_info *page;
>       unsigned long mfn = gmfn_to_mfn(d, gfn);
>
> -    ASSERT(t == NULL);
> -

I would set *t to INT_MAX, for now. This will ensure that t is 
"correctly" initialized.

-- 
Julien Grall