From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: arm: handle initrd addresses above the 4G boundary
Date: Mon, 09 Dec 2013 13:52:21 +0000 [thread overview]
Message-ID: <52A5CB15.6020301@linaro.org> (raw)
In-Reply-To: <1386587735.30459.10.camel@kazak.uk.xensource.com>
On 12/09/2013 11:15 AM, Ian Campbell wrote:
> On Fri, 2013-12-06 at 17:39 +0000, Julien Grall wrote:
>>>> Perhaps you update the comment by saying we are assuming bytes is 4-byte
>>>> aligned.
>>>
>>> Maybe it would be better to round up?
>>
>> No because if we round up, we would read to much data. dt_read_number is
>> not able to check the size.
>
> Right.
>
> I think what I shall do is change the caller to accept exactly
> sizeof(u32) or sizeof(u64) bytes and not any value between.
It's fine to have size between sizeof(u32) or sizeof(u64), the address
will just be truncated.
We have several location in Xen, where we rely on this behavior.
--
Julien Grall
next prev parent reply other threads:[~2013-12-09 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 14:42 [PATCH] xen: arm: handle initrd addresses above the 4G boundary Ian Campbell
2013-12-06 15:50 ` Julien Grall
2013-12-06 16:58 ` Ian Campbell
2013-12-06 17:39 ` Julien Grall
2013-12-09 11:15 ` Ian Campbell
2013-12-09 13:52 ` Julien Grall [this message]
2013-12-09 14:00 ` Ian Campbell
2013-12-09 14:11 ` Julien Grall
2013-12-09 14:15 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A5CB15.6020301@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).