From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: arm: handle initrd addresses above the 4G boundary Date: Mon, 09 Dec 2013 13:52:21 +0000 Message-ID: <52A5CB15.6020301@linaro.org> References: <1386254540-14231-1-git-send-email-ian.campbell@citrix.com> <52A1F238.90900@linaro.org> <1386349114.6672.61.camel@kazak.uk.xensource.com> <52A20BE5.6020702@linaro.org> <1386587735.30459.10.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386587735.30459.10.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 12/09/2013 11:15 AM, Ian Campbell wrote: > On Fri, 2013-12-06 at 17:39 +0000, Julien Grall wrote: >>>> Perhaps you update the comment by saying we are assuming bytes is 4-byte >>>> aligned. >>> >>> Maybe it would be better to round up? >> >> No because if we round up, we would read to much data. dt_read_number is >> not able to check the size. > > Right. > > I think what I shall do is change the caller to accept exactly > sizeof(u32) or sizeof(u64) bytes and not any value between. It's fine to have size between sizeof(u32) or sizeof(u64), the address will just be truncated. We have several location in Xen, where we rely on this behavior. -- Julien Grall