From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 03/10] xen/arm: Implement p2m_type_t as an enum Date: Tue, 10 Dec 2013 02:02:25 +0000 Message-ID: <52A67631.7020300@linaro.org> References: <1386560047-17500-1-git-send-email-julien.grall@linaro.org> <1386560047-17500-4-git-send-email-julien.grall@linaro.org> <1386604743.7812.34.camel@kazak.uk.xensource.com> <52A5F129.9020500@linaro.org> <1386608049.7812.69.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VqCeb-0004Z3-0Y for xen-devel@lists.xenproject.org; Tue, 10 Dec 2013 02:02:29 +0000 Received: by mail-wi0-f172.google.com with SMTP id en1so4720828wid.5 for ; Mon, 09 Dec 2013 18:02:27 -0800 (PST) In-Reply-To: <1386608049.7812.69.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 12/09/2013 04:54 PM, Ian Campbell wrote: > On Mon, 2013-12-09 at 16:34 +0000, Julien Grall wrote: >> On 12/09/2013 03:59 PM, Ian Campbell wrote: >>> On Mon, 2013-12-09 at 03:34 +0000, Julien Grall wrote: >>>> + p2m_max_real_type, /* Types after this won't be store in the p2m */ >>> >>> Did you intend to add a BUILD_BUG_ON referencing this last one? >> >> The BUILD_BUG_ON is added by patch #4. > > So it is. Perhaps it should either be in this patch or you should add > max_real_type in that patch. I have moved the BUILD_BUG_ON in this patch. -- Julien Grall