From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 3/5] x86/p2m: restrict auditing to debug builds Date: Tue, 10 Dec 2013 15:58:04 +0000 Message-ID: <52A73A0C.4090603@citrix.com> References: <52A744B7020000780010BEF1@nat28.tlf.novell.com> <52A74595020000780010BF27@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5498786047774726406==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VqPkK-0007zP-2x for xen-devel@lists.xenproject.org; Tue, 10 Dec 2013 16:01:16 +0000 In-Reply-To: <52A74595020000780010BF27@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , xen-devel , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org --===============5498786047774726406== Content-Type: multipart/alternative; boundary="------------070408020001010900030109" --------------070408020001010900030109 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 10/12/13 15:47, Jan Beulich wrote: > ... since iterating through all of a guest's pages may take unduly > long. > > Signed-off-by: Jan Beulich > Acked-by: Ian Campbell Reviewed-by: Andrew Cooper > > --- a/xen/include/asm-x86/p2m.h > +++ b/xen/include/asm-x86/p2m.h > @@ -600,7 +600,11 @@ int set_p2m_entry(struct p2m_domain *p2m > extern void p2m_pt_init(struct p2m_domain *p2m); > > /* Debugging and auditing of the P2M code? */ > +#ifndef NDEBUG > #define P2M_AUDIT 1 > +#else > +#define P2M_AUDIT 0 > +#endif > #define P2M_DEBUGGING 0 > > #if P2M_AUDIT > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------070408020001010900030109 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 10/12/13 15:47, Jan Beulich wrote:
... since iterating through all of a guest's pages may take unduly
long.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -600,7 +600,11 @@ int set_p2m_entry(struct p2m_domain *p2m
 extern void p2m_pt_init(struct p2m_domain *p2m);
 
 /* Debugging and auditing of the P2M code? */
+#ifndef NDEBUG
 #define P2M_AUDIT     1
+#else
+#define P2M_AUDIT     0
+#endif
 #define P2M_DEBUGGING 0
 
 #if P2M_AUDIT






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------070408020001010900030109-- --===============5498786047774726406== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5498786047774726406==--