From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 4/5] HVM: prevent leaking heap data from
	hvm_save_one()
Date: Tue, 10 Dec 2013 17:32:10 +0000
Message-ID: <52A7501A.5080403@eu.citrix.com>
References: <52A744B7020000780010BEF1@nat28.tlf.novell.com>
	<52A745C0020000780010BF2A@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1VqRAc-0005NJ-B2
	for xen-devel@lists.xenproject.org; Tue, 10 Dec 2013 17:32:30 +0000
In-Reply-To: <52A745C0020000780010BF2A@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Don Slutz <dslutz@verizon.com>
List-Id: xen-devel@lists.xenproject.org

On 12/10/2013 03:48 PM, Jan Beulich wrote:
> When one or more of the vCPU-s of a guest are offline, no data may be
> put into the allocated space for them and, due to another bug, such
> uninitialized data may be passed back to the caller.
>
> Signed-off-by: Don Slutz <dslutz@verizon.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>

>
> --- a/xen/common/hvm/save.c
> +++ b/xen/common/hvm/save.c
> @@ -102,7 +102,7 @@ int hvm_save_one(struct domain *d, uint1
>           return -EINVAL;
>   
>       ctxt.size = sz;
> -    ctxt.data = xmalloc_bytes(sz);
> +    ctxt.data = xzalloc_bytes(sz);
>       if ( !ctxt.data )
>           return -ENOMEM;
>   
>
>
>