From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org
Subject: Re: [PATCH v3 3/6] xen/arm: do not add a second irq to the LRs if one is already present
Date: Tue, 10 Dec 2013 22:06:44 +0000 [thread overview]
Message-ID: <52A79074.3060900@linaro.org> (raw)
In-Reply-To: <1386701456-20307-3-git-send-email-stefano.stabellini@eu.citrix.com>
On 12/10/2013 06:50 PM, Stefano Stabellini wrote:
> When the guest re-enable IRQs, do not add guest IRQs to LRs twice.
>
> Suggested-by: Julien Grall <julien.grall@linaro.org>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/vgic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index a16bdf1..ab788da 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -370,7 +370,7 @@ static void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n)
> irq = i + (32 * n);
> p = irq_to_pending(v, irq);
> set_bit(_GIC_IRQ_GUEST_ENABLED, &p->status);
> - if ( !list_empty(&p->inflight) )
> + if ( !list_empty(&p->inflight) && !test_bit(_GIC_IRQ_GUEST_VISIBLE, &p->status) )
> gic_set_guest_irq(v, irq, GICH_LR_PENDING, p->priority);
> i++;
> }
>
--
Julien Grall
next prev parent reply other threads:[~2013-12-10 22:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 18:49 [PATCH v3 0/6] interrupt handling fixes Stefano Stabellini
2013-12-10 18:50 ` [PATCH v3 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ Stefano Stabellini
2013-12-10 18:50 ` [PATCH v3 2/6] xen/arm: track the state of guest IRQs Stefano Stabellini
2013-12-11 14:38 ` Ian Campbell
2013-12-11 19:00 ` Stefano Stabellini
2013-12-12 11:55 ` Ian Campbell
2013-12-12 14:55 ` Stefano Stabellini
2013-12-10 18:50 ` [PATCH v3 3/6] xen/arm: do not add a second irq to the LRs if one is already present Stefano Stabellini
2013-12-10 22:06 ` Julien Grall [this message]
2013-12-10 18:50 ` [PATCH v3 4/6] xen/arm: implement gic_irq_enable and gic_irq_disable Stefano Stabellini
2013-12-10 21:30 ` Julien Grall
2013-12-10 18:50 ` [PATCH v3 5/6] xen/arm: Only enable physical IRQs when the guest asks Stefano Stabellini
2013-12-10 21:11 ` Julien Grall
2013-12-11 12:50 ` Stefano Stabellini
2013-12-11 13:34 ` Julien Grall
2013-12-11 13:38 ` Julien Grall
2013-12-11 17:25 ` Stefano Stabellini
2013-12-10 18:50 ` [PATCH v3 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ Stefano Stabellini
2013-12-10 22:05 ` Julien Grall
2013-12-10 22:09 ` [PATCH v3 0/6] interrupt handling fixes Julien Grall
2013-12-11 14:19 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A79074.3060900@linaro.org \
--to=julien.grall@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).