From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 3/6] xen/arm: do not add a second irq to the LRs if one is already present Date: Tue, 10 Dec 2013 22:06:44 +0000 Message-ID: <52A79074.3060900@linaro.org> References: <1386701456-20307-3-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386701456-20307-3-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 12/10/2013 06:50 PM, Stefano Stabellini wrote: > When the guest re-enable IRQs, do not add guest IRQs to LRs twice. > > Suggested-by: Julien Grall > Signed-off-by: Stefano Stabellini > Acked-by: Ian Campbell Acked-by: Julien Grall > --- > xen/arch/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c > index a16bdf1..ab788da 100644 > --- a/xen/arch/arm/vgic.c > +++ b/xen/arch/arm/vgic.c > @@ -370,7 +370,7 @@ static void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n) > irq = i + (32 * n); > p = irq_to_pending(v, irq); > set_bit(_GIC_IRQ_GUEST_ENABLED, &p->status); > - if ( !list_empty(&p->inflight) ) > + if ( !list_empty(&p->inflight) && !test_bit(_GIC_IRQ_GUEST_VISIBLE, &p->status) ) > gic_set_guest_irq(v, irq, GICH_LR_PENDING, p->priority); > i++; > } > -- Julien Grall