From: "Egger, Christoph" <chegger@amazon.de>
To: Yang Zhang <yang.z.zhang@intel.com>, xen-devel@lists.xen.org
Cc: eddie.dong@intel.com, JBeulich@suse.com
Subject: Re: [PATCH 1/3] Nested VMX: update nested paging mode when vmswitch is in progress
Date: Thu, 12 Dec 2013 12:04:02 +0100 [thread overview]
Message-ID: <52A99822.4080802@amazon.de> (raw)
In-Reply-To: <1386814004-5574-2-git-send-email-yang.z.zhang@intel.com>
On 12.12.13 03:06, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang@Intel.com>
>
> virtual vmentry will change paging related stucture, so corrensponding
> nested mode need to be updated which is missing currently.
>
> Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
I weakly remember the "!nestedhvm_vmswitch_in_progress" is needed
to avoid a nested pagefault loop on AMD. I do not remember the
actual reproduction case. Unfortunately, I do not have a setup
to verify.
Christoph
> ---
> xen/arch/x86/hvm/hvm.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> This patch fixed RHEL6 guest installation problem with L1 hyper-v.
>
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 69f7e74..1f62e00 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -1925,7 +1925,7 @@ int hvm_set_cr0(unsigned long value)
> hvm_update_cr(v, 0, value);
>
> if ( (value ^ old_value) & X86_CR0_PG ) {
> - if ( !nestedhvm_vmswitch_in_progress(v) && nestedhvm_vcpu_in_guestmode(v) )
> + if ( nestedhvm_vcpu_in_guestmode(v) )
> paging_update_nestedmode(v);
> else
> paging_update_paging_modes(v);
> @@ -2014,7 +2014,7 @@ int hvm_set_cr4(unsigned long value)
> (X86_CR4_PSE | X86_CR4_PGE | X86_CR4_PAE | X86_CR4_SMEP)) ||
> (!(value & X86_CR4_PCIDE) && (old_cr & X86_CR4_PCIDE)) )
> {
> - if ( !nestedhvm_vmswitch_in_progress(v) && nestedhvm_vcpu_in_guestmode(v) )
> + if ( nestedhvm_vcpu_in_guestmode(v) )
> paging_update_nestedmode(v);
> else
> paging_update_paging_modes(v);
>
next prev parent reply other threads:[~2013-12-12 11:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 2:06 [PATCH 0/3] some nested vmx fixing to hyper-v Yang Zhang
2013-12-12 2:06 ` [PATCH 1/3] Nested VMX: update nested paging mode when vmswitch is in progress Yang Zhang
2013-12-12 11:04 ` Egger, Christoph [this message]
2013-12-13 3:30 ` Zhang, Yang Z
2013-12-17 1:10 ` Zhang, Yang Z
2013-12-18 8:58 ` Dong, Eddie
2013-12-18 10:08 ` Jan Beulich
2013-12-18 10:24 ` Zhang, Yang Z
2013-12-18 12:05 ` Egger, Christoph
2013-12-23 1:34 ` Zhang, Yang Z
2013-12-24 11:35 ` Zhang, Yang Z
2014-01-14 2:33 ` Zhang, Yang Z
2014-01-14 7:29 ` Jan Beulich
2014-01-14 7:38 ` Zhang, Yang Z
2014-01-20 9:07 ` Egger, Christoph
2014-01-21 8:49 ` Zhang, Yang Z
2014-01-21 9:46 ` Egger, Christoph
2013-12-18 15:56 ` Dong, Eddie
2013-12-12 2:06 ` [PATCH 2/3] VMX, apicv: Set "NMI-window exiting" for NMI Yang Zhang
2014-01-08 1:23 ` Zhang, Yang Z
2014-01-08 1:28 ` Andrew Cooper
2014-01-08 1:36 ` Zhang, Yang Z
2014-01-08 1:41 ` Zhang, Yang Z
2013-12-12 2:06 ` [PATCH 3/3] Nested VMX: Setup the virtual NMI exiting info Yang Zhang
2013-12-18 9:00 ` Dong, Eddie
2013-12-18 5:39 ` [PATCH 0/3] some nested vmx fixing to hyper-v Zhang, Yang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A99822.4080802@amazon.de \
--to=chegger@amazon.de \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).