From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 1/2] evtchn/fifo: initialize priority when
 events are bound
Date: Mon, 16 Dec 2013 13:45:18 +0000
Message-ID: <52AF03EE.1010202@citrix.com>
References: <1386683820-9834-1-git-send-email-david.vrabel@citrix.com>	<1386683820-9834-2-git-send-email-david.vrabel@citrix.com>
	<52A73830020000780010BE4E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1VsYU6-000109-Qj
	for xen-devel@lists.xenproject.org; Mon, 16 Dec 2013 13:45:23 +0000
In-Reply-To: <52A73830020000780010BE4E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 10/12/13 14:50, Jan Beulich wrote:
>>>> On 10.12.13 at 14:56, David Vrabel <david.vrabel@citrix.com> wrote:
>> From: David Vrabel <david.vrabel@citrix.com>
>>
>> Event channel ports that are reused or that were not in the initial
>> bucket would have a non-default priority.
>>
>> Add an init evtchn_port_op hook and use this to set the priority when
>> an event channel is bound.
>>
>> Within this new evtchn_fifo_init() call, also check if the event is
>> already on a queue and print a warning, as this event may have its
>> first event delivered on a queue with the wrong VCPU or priority.
>> This guest is expected to prevent this (if it cares) by not unbinding
>> events that are still linked.
>>
> 
> Reported-by: Jan Beulich <jbeulich@suse.com>
> 
>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Keir,  if you hadn't noticed, this touches common code and thus needs
your ack.

I would like to see these fixes go in prior to the first RC as without
patch 2, the FIFO event channels don't really work if irqbalanced is
used (which seems to be a common setup[1]).

David

[1] Except my main test box for some reason...