From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [BUGFIX][PATCH 3/4] hvm_save_one: return correct data. Date: Tue, 17 Dec 2013 10:40:10 +0000 Message-ID: <52B02A0A.8@citrix.com> References: <1386809777-12898-1-git-send-email-dslutz@terremark.com> <1386809777-12898-4-git-send-email-dslutz@terremark.com> <52AB25B4020000780010D0B0@nat28.tlf.novell.com> <52ACF7CE.9030904@terremark.com> <52ADDE15.8010408@citrix.com> <52AEC522020000780010D7BE@nat28.tlf.novell.com> <52AF3D91.6000809@terremark.com> <52B0174D020000780010E015@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vss4U-0004oT-Ii for xen-devel@lists.xenproject.org; Tue, 17 Dec 2013 10:40:14 +0000 In-Reply-To: <52B0174D020000780010E015@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , Ian Jackson , Don Slutz , xen-devel List-Id: xen-devel@lists.xenproject.org On 17/12/13 08:20, Jan Beulich wrote: >>>> On 16.12.13 at 18:51, Don Slutz wrote: >> I feel that the attached bugfix patch is simple enough to make it into 4.4 >> and also be back ported to stable branches. > I would tend to agree on the 4.4 part of this, but afaict this is used > for debugging purposes only, so I'm not so sure about backporting > to stable branches. What is your rationale behind that request? > > Andrew, short of taking your intrusive (and not yet agreed upon) > rework - would you agree Don's change at least is a sufficient > improvement to include it irrespective of any intentions you might > have with this code? > > Jan > Yes - Dons' patch would appear to fix up all the corner-cases I am aware of in the hypercall. ~Andrew