xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
	stefano.stabellini@citrix.com, patches@linaro.org
Subject: Re: [PATCH v5 07/10] xen/arm: Handle remove foreign mapping
Date: Tue, 17 Dec 2013 15:44:34 +0000	[thread overview]
Message-ID: <52B07162.1030209@linaro.org> (raw)
In-Reply-To: <1387293710.27441.73.camel@kazak.uk.xensource.com>

On 12/17/2013 03:21 PM, Ian Campbell wrote:
> On Tue, 2013-12-17 at 15:06 +0000, Julien Grall wrote:
>> On 12/17/2013 11:18 AM, Ian Campbell wrote:
>> The patch #8 which relinquish memory doesn't give the right mfn in
>> parameters.
>> It's because, you will need to look for each gfn the translated mfn (you
>> can't assumed the mfn are contiguous). So the loop will go back to the
>> version 3.
> 
> I'm not sure what you mean.
> 
> All I was trying to say is that:
> 	mfn = paddr_to_pfn(pte.bits & PADDR_MASK & PAGE_MASK)
> is (probably) equivalent to:
> 	mfn = pte.p2m.base

We didn't talk about the same thing.

I will use pte.p2m.base for the next version.


-- 
Julien Grall

  reply	other threads:[~2013-12-17 15:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 17:37 [PATCH v5 00/10] xen/arm: Handle correctly foreign mapping Julien Grall
2013-12-16 17:37 ` [PATCH v5 01/10] xen/arm: Introduce steps in domain_relinquish_resource Julien Grall
2013-12-16 17:37 ` [PATCH v5 02/10] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c Julien Grall
2013-12-16 17:37 ` [PATCH v5 03/10] xen/arm: Implement p2m_type_t as an enum Julien Grall
2013-12-16 17:37 ` [PATCH v5 04/10] xen/arm: Store p2m type in each page of the guest Julien Grall
2013-12-16 17:49   ` Ian Campbell
2013-12-16 22:54     ` Julien Grall
2013-12-16 17:37 ` [PATCH v5 05/10] xen/arm: p2m: Extend p2m_lookup parameters to retrieve the p2m type Julien Grall
2013-12-17 11:12   ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 06/10] xen/arm: Retrieve p2m type in get_page_from_gfn Julien Grall
2013-12-17 11:13   ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 07/10] xen/arm: Handle remove foreign mapping Julien Grall
2013-12-17 11:18   ` Ian Campbell
2013-12-17 15:06     ` Julien Grall
2013-12-17 15:21       ` Ian Campbell
2013-12-17 15:44         ` Julien Grall [this message]
2013-12-17 15:45           ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page Julien Grall
2013-12-17  9:26   ` Ian Campbell
2013-12-17 10:03     ` Jan Beulich
2013-12-17 10:12       ` Ian Campbell
2013-12-17 14:08     ` Julien Grall
2013-12-17 14:13       ` Ian Campbell
2013-12-17 14:40     ` Julien Grall
2013-12-17 14:42       ` Ian Campbell
2013-12-17 14:45         ` Julien Grall
2013-12-17 14:52           ` Ian Campbell
2013-12-17 14:57             ` Julien Grall
2013-12-17 11:31   ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 09/10] xen/arm: Set foreign page type to p2m_map_foreign Julien Grall
2013-12-17 11:34   ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 10/10] xen/arm: grant-table: Support read-only mapping Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B07162.1030209@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=patches@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).