From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 07/10] xen/arm: Handle remove foreign mapping Date: Tue, 17 Dec 2013 15:44:34 +0000 Message-ID: <52B07162.1030209@linaro.org> References: <1387215452-10951-1-git-send-email-julien.grall@linaro.org> <1387215452-10951-8-git-send-email-julien.grall@linaro.org> <1387279118.27441.40.camel@kazak.uk.xensource.com> <52B06874.5020608@linaro.org> <1387293710.27441.73.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vswp7-0001Ax-2G for xen-devel@lists.xenproject.org; Tue, 17 Dec 2013 15:44:41 +0000 Received: by mail-ea0-f177.google.com with SMTP id n15so3002236ead.8 for ; Tue, 17 Dec 2013 07:44:39 -0800 (PST) In-Reply-To: <1387293710.27441.73.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On 12/17/2013 03:21 PM, Ian Campbell wrote: > On Tue, 2013-12-17 at 15:06 +0000, Julien Grall wrote: >> On 12/17/2013 11:18 AM, Ian Campbell wrote: >> The patch #8 which relinquish memory doesn't give the right mfn in >> parameters. >> It's because, you will need to look for each gfn the translated mfn (you >> can't assumed the mfn are contiguous). So the loop will go back to the >> version 3. > > I'm not sure what you mean. > > All I was trying to say is that: > mfn = paddr_to_pfn(pte.bits & PADDR_MASK & PAGE_MASK) > is (probably) equivalent to: > mfn = pte.p2m.base We didn't talk about the same thing. I will use pte.p2m.base for the next version. -- Julien Grall