From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Don Slutz <dslutz@verizon.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Keir Fraser <keir@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [BUGFIX][PATCH 3/4] hvm_save_one: return correct data.
Date: Tue, 17 Dec 2013 10:58:56 -0500 [thread overview]
Message-ID: <52B074C0.4030407@terremark.com> (raw)
In-Reply-To: <52B0174D020000780010E015@nat28.tlf.novell.com>
On 12/17/13 03:20, Jan Beulich wrote:
>>>> On 16.12.13 at 18:51, Don Slutz <dslutz@verizon.com> wrote:
>> I feel that the attached bugfix patch is simple enough to make it into 4.4
>> and also be back ported to stable branches.
> I would tend to agree on the 4.4 part of this, but afaict this is used
> for debugging purposes only, so I'm not so sure about backporting
> to stable branches. What is your rationale behind that request?
I would think that getting bad info during debugging to be important. For example:
Before (i.e. correct data):
# xenctx 7 7
rip: ffffffff8006b2b0
flags: 00000246 i z p
rsp: ffff8100bfe6bef0
rax: 0000000000000000 rcx: 0000000000000000 rdx: 0000000000000000
rbx: ffffffff8006b287 rsi: 0000000000000001 rdi: ffffffff802f0658
rbp: 0000000000000007 r8: ffff8100bfe6a000 r9: 0000000000000039
r10: ffff8100b80a5b40 r11: ffff810037fe6100 r12: 00000000000000ff
r13: ffffffff803b4680 r14: 0000000000000700 r15: ffffffff803d6340
cs: 0010 ss: 0018 ds: 0018 es: 0018
fs: 0000 @ 0000000000000000
gs: 0000 @ ffff8100bfe17340/0000000000000000
Code (instr addr ffffffff8006b2b0)
65 48 8b 04 25 10 00 00 00 8b 80 38 e0 ff ff a8 08 75 04 fb f4 <eb> 01 fb 65 48 8b 04 25 10 00 00
Stack:
ffffffff80048d19 00000000000000e0 ffffffff80076be6 ffffffff803d4360
0000000000000000 0000000000000000 0000000000000000 0000000000000000
0000000000000000 0000000000000000 0000000000000000 0000000000000000
0000000000000000 0000000000000000 0000000000000000 0000000000000000
0000000000000000 0000000000000000 0000000000000000 0000000000000000
Call Trace:
[<ffffffff8006b2b0>] <--
[<ffffffff80048d19>]
[<ffffffff80076be6>]
[<ffffffff803d4360>]
After offline of vcpu 1:
# xenctx 7 7
cs:eip: 0010:8006b2b0
flags: 00000246 i z p
ss:esp: 0018:bfe6bef0
eax: 00000000 ebx: 8006b287 ecx: 00000000 edx: 00000000
esi: 00000001 edi: 802f0658 ebp: 00000007
ds: 0018 es: 0018 fs: 0000 gs: 0000
Code (instr addr ffffffff8006b2b0)
f0 53 ff 00 f0 53 ff 00 f0 53 ff 00 f0 53 ff 00 f0 53 ff 00 f0 <53> ff 00 f0 53 ff 00 f0 53 ff 00
Stack:
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Call Trace:
[<ffffffff8006b2b0>] <--
As you can see, it now looks like VCPU 7 is in 32 bit mode when it is not.
-Don Slutz
> Andrew, short of taking your intrusive (and not yet agreed upon)
> rework - would you agree Don's change at least is a sufficient
> improvement to include it irrespective of any intentions you might
> have with this code?
>
> Jan
>
next prev parent reply other threads:[~2013-12-17 15:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 0:56 [BUGFIX][PATCH 0/4] hvm_save_one: return correct data Don Slutz
2013-12-12 0:56 ` [PATCH 1/4] tools/test: Add check-hvmctx Don Slutz
2013-12-12 0:56 ` [PATCH 2/4] Add tools/tests/offline_module Don Slutz
2013-12-12 10:01 ` Ian Campbell
2013-12-12 11:09 ` David Vrabel
2013-12-12 14:24 ` Don Slutz
2013-12-12 14:32 ` Don Slutz
2013-12-12 0:56 ` [BUGFIX][PATCH 3/4] hvm_save_one: return correct data Don Slutz
2013-12-13 14:20 ` Jan Beulich
2013-12-15 0:29 ` Don Slutz
2013-12-15 16:51 ` Andrew Cooper
2013-12-15 17:19 ` Don Slutz
2013-12-15 17:22 ` Andrew Cooper
2013-12-15 17:42 ` Don Slutz
2013-12-15 18:11 ` Andrew Cooper
2013-12-15 18:41 ` Don Slutz
2013-12-15 19:06 ` Andrew Cooper
2013-12-15 19:23 ` Don Slutz
2013-12-16 8:17 ` Jan Beulich
2013-12-16 17:51 ` Don Slutz
2013-12-16 18:33 ` Andrew Cooper
2013-12-22 19:40 ` Don Slutz
2013-12-22 21:13 ` Andrew Cooper
2014-01-07 15:55 ` Keir Fraser
2013-12-17 8:20 ` Jan Beulich
2013-12-17 10:40 ` Andrew Cooper
2013-12-20 0:32 ` Don Slutz
2013-12-20 13:31 ` George Dunlap
2013-12-22 19:44 ` Don Slutz
2013-12-17 15:58 ` Don Slutz [this message]
2013-12-12 0:56 ` [BUGFIX][PATCH 4/4] hvm_save_one: allow the 2nd instance to be fetched for PIC Don Slutz
2013-12-13 14:38 ` Jan Beulich
2013-12-15 1:38 ` Don Slutz
2013-12-16 8:22 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B074C0.4030407@terremark.com \
--to=dslutz@verizon.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).