xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [BUGFIX][PATCH 3/4] hvm_save_one: return correct data.
Date: Fri, 20 Dec 2013 13:31:09 +0000	[thread overview]
Message-ID: <52B4469D.1060102@eu.citrix.com> (raw)
In-Reply-To: <52B39006.8040707@terremark.com>

On 12/20/2013 12:32 AM, Don Slutz wrote:
> Adding "George Dunlap" to list of people.
>
> George,
>   I think this is a bug fix that can make it into 4.4.  Some how I 
> forgot to include you directly.  Please let me know if pushing for 
> this is wrong.
>
> Bug fix is attached to:
>
> http://lists.xen.org/archives/html/xen-devel/2013-12/msg02412.html
>
> Thanks,
>    -Don Slutz
>
> On 12/17/13 05:40, Andrew Cooper wrote:
>> On 17/12/13 08:20, Jan Beulich wrote:
>>>>>> On 16.12.13 at 18:51, Don Slutz <dslutz@verizon.com> wrote:
>>>> I feel that the attached bugfix patch is simple enough to make it 
>>>> into 4.4
>>>> and also be back ported to stable branches.
>>> I would tend to agree on the 4.4 part of this, but afaict this is used
>>> for debugging purposes only, so I'm not so sure about backporting
>>> to stable branches. What is your rationale behind that request?
>>>
>>> Andrew, short of taking your intrusive (and not yet agreed upon)
>>> rework - would you agree Don's change at least is a sufficient
>>> improvement to include it irrespective of any intentions you might
>>> have with this code?
>>>
>>> Jan
>>>
>> Yes - Dons' patch would appear to fix up all the corner-cases I am aware
>> of in the hypercall.

It looks like this should only affect xenctx.  It is a bug fix, and 
while not a critical one, nonetheless an important one.  So I agree, it 
should be accepted.

Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>

  reply	other threads:[~2013-12-20 13:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-12  0:56 [BUGFIX][PATCH 0/4] hvm_save_one: return correct data Don Slutz
2013-12-12  0:56 ` [PATCH 1/4] tools/test: Add check-hvmctx Don Slutz
2013-12-12  0:56 ` [PATCH 2/4] Add tools/tests/offline_module Don Slutz
2013-12-12 10:01   ` Ian Campbell
2013-12-12 11:09     ` David Vrabel
2013-12-12 14:24       ` Don Slutz
2013-12-12 14:32         ` Don Slutz
2013-12-12  0:56 ` [BUGFIX][PATCH 3/4] hvm_save_one: return correct data Don Slutz
2013-12-13 14:20   ` Jan Beulich
2013-12-15  0:29     ` Don Slutz
2013-12-15 16:51       ` Andrew Cooper
2013-12-15 17:19         ` Don Slutz
2013-12-15 17:22           ` Andrew Cooper
2013-12-15 17:42             ` Don Slutz
2013-12-15 18:11               ` Andrew Cooper
2013-12-15 18:41                 ` Don Slutz
2013-12-15 19:06                   ` Andrew Cooper
2013-12-15 19:23                     ` Don Slutz
2013-12-16  8:17         ` Jan Beulich
2013-12-16 17:51           ` Don Slutz
2013-12-16 18:33             ` Andrew Cooper
2013-12-22 19:40               ` Don Slutz
2013-12-22 21:13                 ` Andrew Cooper
2014-01-07 15:55                 ` Keir Fraser
2013-12-17  8:20             ` Jan Beulich
2013-12-17 10:40               ` Andrew Cooper
2013-12-20  0:32                 ` Don Slutz
2013-12-20 13:31                   ` George Dunlap [this message]
2013-12-22 19:44                     ` Don Slutz
2013-12-17 15:58               ` Don Slutz
2013-12-12  0:56 ` [BUGFIX][PATCH 4/4] hvm_save_one: allow the 2nd instance to be fetched for PIC Don Slutz
2013-12-13 14:38   ` Jan Beulich
2013-12-15  1:38     ` Don Slutz
2013-12-16  8:22       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B4469D.1060102@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dslutz@verizon.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).