From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 5/6] xen/console: Add noreturn attribute to panic function Date: Mon, 06 Jan 2014 11:39:36 +0000 Message-ID: <52CA95F8.1080907@linaro.org> References: <1388957191-10337-1-git-send-email-julien.grall@linaro.org> <1388957191-10337-6-git-send-email-julien.grall@linaro.org> <52C9E034.1020707@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W08X2-0006Wv-3s for xen-devel@lists.xenproject.org; Mon, 06 Jan 2014 11:39:44 +0000 Received: by mail-la0-f45.google.com with SMTP id eh20so9775559lab.18 for ; Mon, 06 Jan 2014 03:39:42 -0800 (PST) In-Reply-To: <52C9E034.1020707@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: tim@xen.org, patches@linaro.org, Keir Fraser , ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 01/05/2014 10:44 PM, Andrew Cooper wrote: > On 05/01/2014 21:26, Julien Grall wrote: >> Panic function will never return. Without this attribute, gcc may output >> warnings in call function. >> >> Cc: Keir Fraser >> Signed-off-by: Julien Grall > > I have a longer series doing rather more noreturn'ing than just this, if > you can wait until the 4.5 dev window opens up again. I'm not sure to get what you said. When early_panic is converted to panic function, I got some gcc warning which result in errors, because of -Werror. So without this small patch, this series can't compile. -- Julien Grall