From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [RFC 5/6] xen/console: Add noreturn attribute to panic function Date: Mon, 6 Jan 2014 11:42:25 +0000 Message-ID: <52CA96A1.2080406@citrix.com> References: <1388957191-10337-1-git-send-email-julien.grall@linaro.org> <1388957191-10337-6-git-send-email-julien.grall@linaro.org> <52C9E034.1020707@citrix.com> <52CA95F8.1080907@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1W08Zh-0006iw-De for xen-devel@lists.xenproject.org; Mon, 06 Jan 2014 11:42:29 +0000 In-Reply-To: <52CA95F8.1080907@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Keir Fraser , ian.campbell@citrix.com, patches@linaro.org, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 06/01/14 11:39, Julien Grall wrote: > > > On 01/05/2014 10:44 PM, Andrew Cooper wrote: >> On 05/01/2014 21:26, Julien Grall wrote: >>> Panic function will never return. Without this attribute, gcc may >>> output >>> warnings in call function. >>> >>> Cc: Keir Fraser >>> Signed-off-by: Julien Grall >> >> I have a longer series doing rather more noreturn'ing than just this, if >> you can wait until the 4.5 dev window opens up again. > > I'm not sure to get what you said. When early_panic is converted to > panic function, I got some gcc warning which result in errors, because > of -Werror. > > So without this small patch, this series can't compile. > My series makes panic() (along with other several other function) properly noreturn, so you don't need the while(1); at the end. i.e., if your series can wait until after mine is committed, this problem will disappear. ~Andrew