From: Jim Fehlig <jfehlig@suse.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 00/12] libxl: fork: SIGCHLD flexibility
Date: Thu, 23 Jan 2014 21:27:03 -0700 [thread overview]
Message-ID: <52E1EB97.4080007@suse.com> (raw)
In-Reply-To: <21216.62800.746512.422459@mariner.uk.xensource.com>
Ian Jackson wrote:
> Jim Fehlig writes ("Re: [Xen-devel] [PATCH 00/12] libxl: fork: SIGCHLD flexibility"):
>
>> It appears the timeout_modify callback is invoked on a previously
>> deregistered timeout. I didn't notice the segfault when running
>> libvirtd under valgrind, but did see
>>
>
> Hmmm. This could be a libxl problem. I'll review the code again and
> maybe think about adding some assertions.
>
BTW, I only see the crash when the save/restore script is running. I
stopped the other scripts and domains, running only save/restore on a
single domain, and see the crash rather quickly (within 10 iterations).
> But I've slept on this and I had an idea about libvirt's rescheduling
> timeouts.
I'm not so thrilled with the timeout handling code in the libvirt libxl
driver. The driver maintains a list of active timeouts because IIRC,
there were cases when the driver received timeout deregistrations when
calling libxl_ctx_free, at which point some of the associated structures
were freed. The idea was to call libxl_osevent_occurred_timeout on any
active timeouts before freeing libxlDomainObjPrivate and its contents.
Regards,
Jim
next prev parent reply other threads:[~2014-01-24 4:27 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 16:23 [PATCH 00/12] libxl: fork: SIGCHLD flexibility Ian Jackson
2014-01-17 16:23 ` [PATCH 01/12] libxl: fork: Break out checked_waitpid Ian Jackson
2014-01-17 16:23 ` [PATCH 02/12] libxl: fork: Break out childproc_reaped_ours Ian Jackson
2014-01-17 16:23 ` [PATCH 03/12] libxl: fork: Clarify docs for libxl_sigchld_owner Ian Jackson
2014-01-17 16:23 ` [PATCH 04/12] libxl: fork: Document libxl_sigchld_owner_libxl better Ian Jackson
2014-01-17 16:28 ` Ian Campbell
2014-01-17 16:23 ` [PATCH 05/12] libxl: fork: assert that chldmode is right Ian Jackson
2014-01-17 16:23 ` [PATCH 06/12] libxl: fork: Provide libxl_childproc_sigchld_occurred Ian Jackson
2014-01-17 16:24 ` [PATCH 07/12] libxl: fork: Provide ..._always_selective_reap Ian Jackson
2014-01-17 22:17 ` Jim Fehlig
2014-01-17 16:24 ` [PATCH 08/12] libxl: fork: Provide LIBXL_HAVE_SIGCHLD_SELECTIVE_REAP Ian Jackson
2014-01-17 16:24 ` [PATCH 09/12] libxl: fork: Rename sigchld handler functions Ian Jackson
2014-01-20 9:59 ` Ian Campbell
2014-01-17 16:24 ` [PATCH 10/12] libxl: fork: Break out sigchld_installhandler_core Ian Jackson
2014-01-20 9:59 ` Ian Campbell
2014-01-17 16:24 ` [PATCH 11/12] libxl: fork: Break out sigchld_sethandler_raw Ian Jackson
2014-01-20 9:58 ` Ian Campbell
2014-01-20 17:57 ` Ian Jackson
2014-01-17 16:24 ` [PATCH 12/12] libxl: fork: Share SIGCHLD handler amongst ctxs Ian Jackson
2014-01-17 18:13 ` Ian Jackson
2014-01-20 9:56 ` Ian Campbell
2014-01-21 14:40 ` Ian Jackson
2014-01-21 14:53 ` Ian Campbell
2014-01-21 15:09 ` Ian Jackson
2014-01-17 16:37 ` [PATCH 00/12] libxl: fork: SIGCHLD flexibility Ian Jackson
2014-01-17 22:29 ` Jim Fehlig
2014-01-20 18:14 ` Jim Fehlig
2014-01-21 14:46 ` Ian Jackson
2014-01-21 15:11 ` [PATCH 13/12] libxl: events: Break out libxl__pipe_nonblock, _close Ian Jackson
2014-01-21 15:11 ` [PATCH 14/12] libxl: fork: Make SIGCHLD self-pipe nonblocking Ian Jackson
2014-01-21 15:32 ` Ian Campbell
2014-01-21 15:48 ` Ian Jackson
2014-01-21 15:27 ` [PATCH 13/12] libxl: events: Break out libxl__pipe_nonblock, _close Ian Campbell
2014-01-21 15:31 ` Ian Jackson
2014-01-21 15:28 ` [PATCH 00/12] libxl: fork: SIGCHLD flexibility Ian Jackson
2014-01-22 5:32 ` Jim Fehlig
2014-01-23 4:05 ` Jim Fehlig
2014-01-23 10:56 ` Ian Jackson
2014-01-23 21:36 ` Jim Fehlig
2014-01-24 4:27 ` Jim Fehlig [this message]
2014-01-24 12:41 ` Ian Jackson
2014-01-24 12:52 ` Ian Campbell
2014-01-24 15:14 ` Ian Jackson
2014-01-24 15:18 ` Ian Jackson
2014-01-24 16:36 ` Ian Jackson
2014-01-24 16:57 ` Ian Jackson
2014-01-27 5:39 ` Jim Fehlig
2014-01-27 5:22 ` Jim Fehlig
2014-01-27 14:48 ` Ian Jackson
2014-01-28 1:39 ` [libvirt] [Xen-devel] " Jim Fehlig
2014-01-28 10:06 ` Daniel P. Berrange
2014-01-29 16:23 ` [libvirt] " Ian Jackson
2014-01-30 12:18 ` [libvirt] [Xen-devel] " Daniel P. Berrange
2014-01-30 16:14 ` Jim Fehlig
2014-01-30 16:17 ` Daniel P. Berrange
2014-01-30 16:28 ` Ian Jackson
2014-01-30 16:56 ` Jim Fehlig
2014-01-30 17:12 ` [libvirt] [Xen-devel] " Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E1EB97.4080007@suse.com \
--to=jfehlig@suse.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).