From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH V6] xen: arm: platforms: Adding reset support for xgene arm64 platform. Date: Mon, 27 Jan 2014 12:01:25 +0000 Message-ID: <52E64A95.2050201@eu.citrix.com> References: <1390822488-22183-1-git-send-email-pranavkumar@linaro.org> <1390822680.12230.24.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1390822680.12230.24.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Pranavkumar Sawargaonkar Cc: patches@apm.com, patches@linaro.org, stefano.stabellini@citrix.com, Anup Patel , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 01/27/2014 11:38 AM, Ian Campbell wrote: > On Mon, 2014-01-27 at 17:04 +0530, Pranavkumar Sawargaonkar wrote: >> This patch adds a reset support for xgene arm64 platform. >> >> V6: >> - Incorporating comments received on V5 patch. >> V5: >> - Incorporating comments received on V4 patch. >> V4: >> - Removing TODO comment about retriving reset base address from dts >> as that is done now. >> V3: >> - Retriving reset base address and reset mask from device tree. >> - Removed unnecssary header files included earlier. >> V2: >> - Removed unnecssary mdelay in code. >> - Adding iounmap of the base address. >> V1: >> -Initial patch. >> >> Signed-off-by: Pranavkumar Sawargaonkar >> Signed-off-by: Anup Patel > Looks good, thanks: > Acked-by: Ian Campbell > > George, I'd like to put this in 4.4. The impact on non-xgene is non > existent and I think reset is basic functionality which we should > enable. So without this patch, support for xgene would be considered "experimental" (missing basic functionality)? -George