Re: [PATCH V6] xen: arm: platforms: Adding reset support for xgene arm64 platform.

[George Dunlap <george.dunlap@eu.citrix.com>]

On 01/27/2014 12:04 PM, Ian Campbell wrote:
> On Mon, 2014-01-27 at 12:01 +0000, George Dunlap wrote:
>> On 01/27/2014 11:38 AM, Ian Campbell wrote:
>>> On Mon, 2014-01-27 at 17:04 +0530, Pranavkumar Sawargaonkar wrote:
>>>> This patch adds a reset support for xgene arm64 platform.
>>>>
>>>> V6:
>>>> - Incorporating comments received on V5 patch.
>>>> V5:
>>>> - Incorporating comments received on V4 patch.
>>>> V4:
>>>> - Removing TODO comment about retriving reset base address from dts
>>>>     as that is done now.
>>>> V3:
>>>> - Retriving reset base address and reset mask from device tree.
>>>> - Removed unnecssary header files included earlier.
>>>> V2:
>>>> - Removed unnecssary mdelay in code.
>>>> - Adding iounmap of the base address.
>>>> V1:
>>>> -Initial patch.
>>>>
>>>> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
>>>> Signed-off-by: Anup Patel <anup.patel@linaro.org>
>>> Looks good, thanks:
>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>
>>> George, I'd like to put this in 4.4. The impact on non-xgene is non
>>> existent and I think reset is basic functionality which we should
>>> enable.
>> So without this patch, support for xgene would be considered
>> "experimental" (missing basic functionality)?
> I don't think I would go so far as to say "experimental", we could
> probably live with it, but having to go find the board and press the
> tiny little button to reboot it is certainly not "complete".

Yes, "can't reboot via software" is a pretty big lack of functionality; 
it weighs in pretty heavily against whatever potential regressions might 
be introduced.

Release-acked-by: George Dunlap <george.dunlap@eu.citrix.com>