From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: libvirt libxl timer handling issue Date: Fri, 31 Jan 2014 08:47:36 -0700 Message-ID: <52EBC598.6030600@suse.com> References: <52EB3C47.9050902@suse.com> <21227.37990.762802.574421@mariner.uk.xensource.com> <21227.48873.879761.827214@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21227.48873.879761.827214@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > Ian Jackson writes ("Re: libvirt libxl timer handling issue"): > >> Jim Fehlig writes ("libvirt libxl timer handling issue"): >> >>> On the bright side, I seem to have the fd event handling issues sorted out. >>> >> Good, I guess. Let me look at your crash stacktrace and the libxl >> code in more detail... >> > > I think this is due to libxl_event.c not clearing the ->func member of > its timeout structs when the timeout occurs. TBH it's surprising that > this hasn't caused more trouble and I haven't been able to test this > so I'm not sure. > > But please take a look at > git://xenbits.xen.org/people/iwj/xen.git#wip.timeout-func0 > > The top two patches there are new; the rest is my fork fixup branch. > Note once again that I have compiled but NOT EXECUTED these two > patches. But since I'm about to be out of touch travelling and then > at FOSDEM I thought I'd send this to you right away. > Ok, thanks. I'll give this a try in a bit. > Sorry if this too turns out to be my fault... > Well, I should spend some time becoming familiar with this part of libxl so I can help fix issues too, instead of whining about them :). Enjoy FOSDEM. Regards, Jim