From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
Subject: Re: blkif: drop struct blkif_request_segment_aligned
Date: Tue, 4 Feb 2014 09:25:31 +0100 [thread overview]
Message-ID: <52F0A3FB.8070108@citrix.com> (raw)
In-Reply-To: <52F0AFC30200007800118E1C@nat28.tlf.novell.com>
On 04/02/14 09:15, Jan Beulich wrote:
> Commit 5148b7b5 ("blkif: add indirect descriptors interface to public
> headers") added this without really explaining why it is needed: The
> structure is identical to struct blkif_request_segment apart from the
> padding field not being given a name in the pre-existing type. Their
> size and alignment - which are what is relevant - are identical as long
> as __alignof__(uint32_t) == 4 (which I think we rely upon in various
> other places, so we can take as given).
>
> Also correct a few minor glitches in the description, including for it
> to no longer assume PAGE_SIZE == 4096.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Thanks for the patch.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
prev parent reply other threads:[~2014-02-04 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 8:15 blkif: drop struct blkif_request_segment_aligned Jan Beulich
2014-02-04 8:25 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F0A3FB.8070108@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).