From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: blkif: drop struct blkif_request_segment_aligned Date: Tue, 4 Feb 2014 09:25:31 +0100 Message-ID: <52F0A3FB.8070108@citrix.com> References: <52F0AFC30200007800118E1C@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WAbK4-0000by-51 for xen-devel@lists.xenproject.org; Tue, 04 Feb 2014 08:25:36 +0000 In-Reply-To: <52F0AFC30200007800118E1C@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On 04/02/14 09:15, Jan Beulich wrote: > Commit 5148b7b5 ("blkif: add indirect descriptors interface to public > headers") added this without really explaining why it is needed: The > structure is identical to struct blkif_request_segment apart from the > padding field not being given a name in the pre-existing type. Their > size and alignment - which are what is relevant - are identical as long > as __alignof__(uint32_t) =3D=3D 4 (which I think we rely upon in various > other places, so we can take as given). > > Also correct a few minor glitches in the description, including for it > to no longer assume PAGE_SIZE =3D=3D 4096. > = > Signed-off-by: Jan Beulich Thanks for the patch. Acked-by: Roger Pau Monn=E9