From: George Dunlap <george.dunlap@eu.citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: anthony.perard@citrix.com, xen-devel@lists.xen.org,
Ian.Jackson@eu.citrix.com, Ian Campbell <Ian.Campbell@citrix.com>,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH for xen-4.4] libxl: add option for discard support to xl disk configuration
Date: Wed, 5 Feb 2014 14:28:01 +0000 [thread overview]
Message-ID: <52F24A71.7080102@eu.citrix.com> (raw)
In-Reply-To: <20140205113623.GA24025@aepfle.de>
On 02/05/2014 11:36 AM, Olaf Hering wrote:
> On Wed, Feb 05, George Dunlap wrote:
>
>> Well it looks like in order to keep ABI compatibility (which I don't think
>> we ever promised), you're introducing this weird hack with overloading a
>> putative boolean value with a magic number?
> Yes, thats the point. If libxl_device_disk changes then IMO the SONAME
> has to change as well. And is 4.4-rc4 is the right time to do that?
> Likely not. I'm fine with carry the 4.4 patch to achieve the result, and
> put the other version into 4.5.
Right, and so this exposes another risk of accepting a patch so late:
that of making poor interface decisions in a rush which either libxl or
programs written against it have to deal with for a long time. (i.e.,
either we have to keep supporting the old interface, or the application
developer has to special case the 4.4 interface if they want to be able
to compile against it).
-George
next prev parent reply other threads:[~2014-02-05 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 12:02 [PATCH v2] libxl: add option for discard support to xl disk configuration Olaf Hering
2014-01-30 12:03 ` [PATCH v2] qemu-upstream: add discard support for xen_disk Olaf Hering
2014-01-30 13:16 ` Stefano Stabellini
2014-01-30 15:32 ` [PATCH v2] libxl: add option for discard support to xl disk configuration Olaf Hering
2014-01-30 15:37 ` Ian Campbell
2014-01-30 16:25 ` [PATCH for xen-4.4] " Olaf Hering
2014-01-30 16:31 ` Ian Campbell
2014-01-30 17:30 ` Olaf Hering
2014-02-04 16:22 ` Ian Campbell
2014-02-05 11:10 ` George Dunlap
2014-02-05 11:36 ` Olaf Hering
2014-02-05 11:46 ` Ian Campbell
2014-02-05 12:27 ` Olaf Hering
2014-02-05 12:34 ` Ian Campbell
2014-02-05 14:28 ` George Dunlap [this message]
2014-02-05 14:56 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F24A71.7080102@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=olaf@aepfle.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).