Xen on ARM: upstream kernel compile fails with defconfig

Xen on ARM: upstream kernel compile fails with defconfig

[Zoltan Kiss]

Hi,

I'm trying to do a default ARM build to verify my grant mapping patches 
doesn't break build. I'm using latest net-next tree as a basis, and I'm 
trying to build it based this howto:

http://wiki.xenproject.org/wiki/Xen_ARMv7_with_Virtualization_Extensions/Allwinner

(note, the actual CPU doesn't matter to me, I just want a default build 
to succeed. Also, net-next is only used because that was checked out, 
and I assume it should work as well)

I'm doing cross-compilation, so my make looks like this:

PATH="/local/repo/arm/gcc-linaro-arm-linux-gnueabihf-4.8-2013.10_linux/bin/:$PATH" 
make -j8 O=../o-arm ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- zImage

For config I've tried sunxi_defconfig (which actually doesn't have Xen 
enabled) and arndale_ubuntu_defconfig from Julien's repo:

http://wiki.xenproject.org/wiki/Xen_ARMv7_with_Virtualization_Extensions/Arndale

However both cases the build fails quite early with the same error:

   CC      arch/arm/kernel/asm-offsets.s
In file included from /local/repo/linux-net-next/include/linux/cache.h:5:0,
                  from /local/repo/linux-net-next/include/linux/printk.h:8,
                  from /local/repo/linux-net-next/include/linux/kernel.h:13,
                  from /local/repo/linux-net-next/include/linux/sched.h:15,
                  from 
/local/repo/linux-net-next/arch/arm/kernel/asm-offsets.c:13:
/local/repo/linux-net-next/include/linux/prefetch.h: In function 
‘prefetch_range’:
/local/repo/linux-net-next/arch/arm/include/asm/cache.h:7:25: error: 
‘CONFIG_ARM_L1_CACHE_SHIFT’ undeclared (first use in this function)
  #define L1_CACHE_SHIFT  CONFIG_ARM_L1_CACHE_SHIFT

So far I figured out that autoconf.h is not included here, that CONFIG_ 
is defined there. But I'm not that familiar with the kernel build 
system, so I'm a bit stucked here. Probably I'm doing something 
trivially wrong, can someone help me?
Btw. on Julian's repo from the Arndale page I could compile, but that's 
too old for my patch to apply. My main goal is to compile an upstream 
kernel with Xen, and then check if my patch breaks it.

Regards,

Zoli

Re: Xen on ARM: upstream kernel compile fails with defconfig

[Julien Grall]

(Add Ian Campbell for sunxi bits)

Hello Zoltan,

On 04/02/14 21:28, Zoltan Kiss wrote: 
> However both cases the build fails quite early with the same error:
> 
>    CC      arch/arm/kernel/asm-offsets.s
> In file included from /local/repo/linux-net-next/include/linux/cache.h:5:0,
>                   from /local/repo/linux-net-next/include/linux/printk.h:8,
>                   from 
> /local/repo/linux-net-next/include/linux/kernel.h:13,
>                   from /local/repo/linux-net-next/include/linux/sched.h:15,
>                   from 
> /local/repo/linux-net-next/arch/arm/kernel/asm-offsets.c:13:
> /local/repo/linux-net-next/include/linux/prefetch.h: In function 
> ‘prefetch_range’:
> /local/repo/linux-net-next/arch/arm/include/asm/cache.h:7:25: error: 
> ‘CONFIG_ARM_L1_CACHE_SHIFT’ undeclared (first use in this function)
>   #define L1_CACHE_SHIFT  CONFIG_ARM_L1_CACHE_SHIFT

I can't get the same error with net-next + your V7. I have this following error:

drivers/xen/grant-table.c: In function ‘__gnttab_unmap_refs’:
drivers/xen/grant-table.c:1047:3: error: implicit declaration of function ‘get_phys_to_machine’ [-Werror=implicit-function-declaration]
   mfn = get_phys_to_machine(page_to_pfn(pages[i]));
   ^

I'm using this config for Linux: http://xenbits.xen.org/people/julieng/config-midway
 
> So far I figured out that autoconf.h is not included here, that CONFIG_ 
> is defined there. But I'm not that familiar with the kernel build 
> system, so I'm a bit stucked here. Probably I'm doing something 
> trivially wrong, can someone help me?
> Btw. on Julian's repo from the Arndale page I could compile, but that's 
> too old for my patch to apply. My main goal is to compile an upstream 
> kernel with Xen, and then check if my patch breaks it.

The kernel repo for the Arndale is completely out-of-date on the wiki page.
I will update the wiki page to use directly the Linaro tree.

Sincerely yours,


-- 
Julien Grall

Re: Xen on ARM: upstream kernel compile fails with defconfig

[Ian Campbell]

On Tue, 2014-02-04 at 21:28 +0000, Zoltan Kiss wrote:
> Hi,
> 
> I'm trying to do a default ARM build to verify my grant mapping patches 
> doesn't break build. I'm using latest net-next tree as a basis, and I'm 
> trying to build it based this howto:
> 
> http://wiki.xenproject.org/wiki/Xen_ARMv7_with_Virtualization_Extensions/Allwinner
> 
> (note, the actual CPU doesn't matter to me, I just want a default build 
> to succeed. Also, net-next is only used because that was checked out, 
> and I assume it should work as well)
> 
> I'm doing cross-compilation, so my make looks like this:
> 
> PATH="/local/repo/arm/gcc-linaro-arm-linux-gnueabihf-4.8-2013.10_linux/bin/:$PATH" 
> make -j8 O=../o-arm ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- zImage
> 
> For config I've tried sunxi_defconfig (which actually doesn't have Xen 
> enabled) and arndale_ubuntu_defconfig from Julien's repo:

I recommend starting from the upstream "multi_v7_defconfig" and the
enabling CONFIG_XEN.

> So far I figured out that autoconf.h is not included here, that CONFIG_ 
> is defined there. But I'm not that familiar with the kernel build 
> system, so I'm a bit stucked here. Probably I'm doing something 
> trivially wrong, can someone help me?

I can't see what -- autoconf.h is included via a direct "-include ...."
passed to the compiler so there aren't many ways for it to go wrong.

Perhaps trying the oldconfig target before building?

Ian.

Re: Xen on ARM: upstream kernel compile fails with defconfig

[Zoltan Kiss]

On 04/02/14 23:35, Julien Grall wrote:
> (Add Ian Campbell for sunxi bits)
>
> Hello Zoltan,
>
> On 04/02/14 21:28, Zoltan Kiss wrote:
>> However both cases the build fails quite early with the same error:
>>
>>     CC      arch/arm/kernel/asm-offsets.s
>> In file included from /local/repo/linux-net-next/include/linux/cache.h:5:0,
>>                    from /local/repo/linux-net-next/include/linux/printk.h:8,
>>                    from
>> /local/repo/linux-net-next/include/linux/kernel.h:13,
>>                    from /local/repo/linux-net-next/include/linux/sched.h:15,
>>                    from
>> /local/repo/linux-net-next/arch/arm/kernel/asm-offsets.c:13:
>> /local/repo/linux-net-next/include/linux/prefetch.h: In function
>> ‘prefetch_range’:
>> /local/repo/linux-net-next/arch/arm/include/asm/cache.h:7:25: error:
>> ‘CONFIG_ARM_L1_CACHE_SHIFT’ undeclared (first use in this function)
>>    #define L1_CACHE_SHIFT  CONFIG_ARM_L1_CACHE_SHIFT
>
> I can't get the same error with net-next + your V7. I have this following error:
>
> drivers/xen/grant-table.c: In function ‘__gnttab_unmap_refs’:
> drivers/xen/grant-table.c:1047:3: error: implicit declaration of function ‘get_phys_to_machine’ [-Werror=implicit-function-declaration]
>     mfn = get_phys_to_machine(page_to_pfn(pages[i]));
>     ^
>
> I'm using this config for Linux: http://xenbits.xen.org/people/julieng/config-midway

OK, I've fixed that, will run some tests before sending v8. I managed to 
fix the compile by checking out the mainline repo. Either net-next has 
some issue, or my checked out repo has some nasty failur (more likely :)

Thanks,

Zoli