xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: keir@xen.org, tim@xen.org, ian.jackson@eu.citrix.com,
	jbeulich@suse.com, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build.
Date: Thu, 06 Feb 2014 14:26:03 +0000	[thread overview]
Message-ID: <52F39B7B.3090208@linaro.org> (raw)
In-Reply-To: <1391616235-22703-3-git-send-email-ian.campbell@citrix.com>

Hi Ian,

On 05/02/14 16:03, Ian Campbell wrote:
> Guests are initially started with caches disabled and so we need to make sure
> they see consistent data in RAM (requiring a cache clean) but also that they
> do not have old stale data suddenly appear in the caches when they enable
> their caches (requiring the invalidate).
>
> This can be split into two halves. First we must flush each page as it is
> allocated to the guest. It is not sufficient to do the flush at scrub time
> since this will miss pages which are ballooned out by the guest (where the
> guest must scrub if it cares about not leaking the pagecontent). We need to
> clean as well as invalidate to make sure that any scrubbing which has occured
> gets committed to real RAM. To achieve this add a new cacheflush_page function,
> which is a stub on x86.
>
> Secondly we need to flush anything which the domain builder touches, which we
> do via a new domctl.

As I understand, there is no hypercall continuation so if a domain give 
a big range Xen will get stuck for a long time (no softirq will be 
handled on the current processor ...). Shall we at least use 
hypercall_create_continuation?

-- 
Julien Grall

  parent reply	other threads:[~2014-02-06 14:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 16:03 [PATCH 0/4 v3] xen/arm: fix guest builder cache cohenrency (again, again) Ian Campbell
2014-02-05 16:03 ` [PATCH v2 1/4] xen: arm: rename create_p2m_entries to apply_p2m_changes Ian Campbell
2014-02-05 16:03 ` [PATCH v2 2/4] xen: arm: rename p2m next_gfn_to_relinquish to lowest_mapped_gfn Ian Campbell
2014-02-05 16:03 ` [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build Ian Campbell
2014-02-06  9:53   ` Jan Beulich
2014-02-06 10:28     ` Ian Campbell
2014-02-06 14:26   ` Julien Grall [this message]
2014-02-06 14:29     ` Ian Campbell
2014-02-06 14:48   ` Julien Grall
2014-02-06 15:04     ` Ian Campbell
2014-02-06 15:41       ` Julien Grall
2014-02-06 15:45         ` Ian Campbell
2014-02-05 16:03 ` [PATCH v2 4/4] Revert "xen: arm: force guest memory accesses to cacheable when MMU is disabled" Ian Campbell
2014-02-07 11:36 ` [PATCH 0/4 v3] xen/arm: fix guest builder cache cohenrency (again, again) George Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2014-02-04 14:21 [PATCH 0/4 v2] " Ian Campbell
2014-02-04 14:22 ` [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build Ian Campbell
2014-02-04 15:00   ` Jan Beulich
2014-02-04 15:43     ` Ian Campbell
2014-02-04 15:48       ` Jan Beulich
2014-02-04 16:07         ` Ian Campbell
2014-02-04 16:42           ` Jan Beulich
2014-02-04 15:32   ` Ian Jackson
2014-02-04 15:37     ` Ian Campbell
2014-02-04 15:55       ` Ian Jackson
2014-02-04 16:09         ` Ian Campbell
2014-02-04 16:16           ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F39B7B.3090208@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).