From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, stefano.stabellini@eu.citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org,
jbeulich@suse.com
Subject: Re: [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build.
Date: Thu, 06 Feb 2014 15:41:21 +0000 [thread overview]
Message-ID: <52F3AD21.5030607@linaro.org> (raw)
In-Reply-To: <1391699058.25128.50.camel@kazak.uk.xensource.com>
On 06/02/14 15:04, Ian Campbell wrote:
> On Thu, 2014-02-06 at 14:48 +0000, Julien Grall wrote:
>>
>> On 05/02/14 16:03, Ian Campbell wrote:
>> > +void sync_page_to_ram(unsigned long mfn)
>>> +{
>>> + void *v = map_domain_page(mfn);
>>> +
>>> + flush_xen_dcache_va_range(v, PAGE_SIZE);
>>> +
>>
>> flush_xen_dcache_va_range uses DCCMVAC (for ARM32 bits), which only
>> clean the cache.
>>
>> Following your commit message, we might want to use DCCIMVAC.
>
> Yes, I think you are right, I thought this function invalidated as well.
I was wondering if we can change the behaviour of
flush_xen_dcache_va_range. Invalidate the cache should not harm the
other call-site.
--
Julien Grall
next prev parent reply other threads:[~2014-02-06 15:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 16:03 [PATCH 0/4 v3] xen/arm: fix guest builder cache cohenrency (again, again) Ian Campbell
2014-02-05 16:03 ` [PATCH v2 1/4] xen: arm: rename create_p2m_entries to apply_p2m_changes Ian Campbell
2014-02-05 16:03 ` [PATCH v2 2/4] xen: arm: rename p2m next_gfn_to_relinquish to lowest_mapped_gfn Ian Campbell
2014-02-05 16:03 ` [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build Ian Campbell
2014-02-06 9:53 ` Jan Beulich
2014-02-06 10:28 ` Ian Campbell
2014-02-06 14:26 ` Julien Grall
2014-02-06 14:29 ` Ian Campbell
2014-02-06 14:48 ` Julien Grall
2014-02-06 15:04 ` Ian Campbell
2014-02-06 15:41 ` Julien Grall [this message]
2014-02-06 15:45 ` Ian Campbell
2014-02-05 16:03 ` [PATCH v2 4/4] Revert "xen: arm: force guest memory accesses to cacheable when MMU is disabled" Ian Campbell
2014-02-07 11:36 ` [PATCH 0/4 v3] xen/arm: fix guest builder cache cohenrency (again, again) George Dunlap
-- strict thread matches above, loose matches on Subject: below --
2014-02-04 14:21 [PATCH 0/4 v2] " Ian Campbell
2014-02-04 14:22 ` [PATCH v2 3/4] xen/arm: clean and invalidate all guest caches by VMID after domain build Ian Campbell
2014-02-04 15:00 ` Jan Beulich
2014-02-04 15:43 ` Ian Campbell
2014-02-04 15:48 ` Jan Beulich
2014-02-04 16:07 ` Ian Campbell
2014-02-04 16:42 ` Jan Beulich
2014-02-04 15:32 ` Ian Jackson
2014-02-04 15:37 ` Ian Campbell
2014-02-04 15:55 ` Ian Jackson
2014-02-04 16:09 ` Ian Campbell
2014-02-04 16:16 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F3AD21.5030607@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).