From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: 4.4.0-rc3 tagged
Date: Fri, 7 Feb 2014 16:29:39 +0000
Message-ID: <52F509F3.1000806@citrix.com>
References: <21227.37769.599789.521146@mariner.uk.xensource.com>
	<52EC2C9C.9090202@terremark.com>
	<21231.33273.164782.738071@mariner.uk.xensource.com>
	<alpine.DEB.2.02.1402031200260.4373@kaball.uk.xensource.com>
	<52F425AD.50209@terremark.com>
	<1391767501.2162.20.camel@kazak.uk.xensource.com>
	<52F5082E.6010207@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1WBoJD-0001lC-HZ
	for xen-devel@lists.xenproject.org; Fri, 07 Feb 2014 16:29:43 +0000
In-Reply-To: <52F5082E.6010207@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>
Cc: xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 07/02/14 16:22, Don Slutz wrote:
> On 02/07/14 05:05, Ian Campbell wrote:
>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote:
>>>>>> cc1: warnings being treated as errors
>>>>>> xenlight_stubs.c: In function 'Defbool_val':
>>>>>> xenlight_stubs.c:344: warning: implicit declaration of function
>>>>>> 'CAMLreturnT'
>>>>>> xenlight_stubs.c:344: error: expected expression before
>>>>>> 'libxl_defbool'
>>>>>> xenlight_stubs.c: In function 'String_option_val':
>>>>>> xenlight_stubs.c:379: error: expected expression before 'char'
>>>>>> xenlight_stubs.c: In function 'aohow_val':
>>>>>> xenlight_stubs.c:440: error: expected expression before
>>>>>> 'libxl_asyncop_how'
>>> Any idea on what to do about ocaml issue?
>> My guess is that your ocaml is too old and doesn't supply CAMLreturnT.
>> What version do you have?
>>
>> Ian.
>>
> dcs-xen-53:~>ocaml -version
> The Objective Caml toplevel, version 3.09.3
>
>    -Don Slutz
>

Which, according to google, was introduced in 3.09.4

I think the ./configure script needs a min version check.

Applying the top macro from
http://docs.camlcity.org/docs/godisrc/oasis-ocaml-fd-1.1.1.tar.gz/ocaml-fd-1.1.1/lib/fd_stubs.c
as a compatibility hack might also be a good idea.

~Andrew