xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Pavlo Suikov <pavlo.suikov@globallogic.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: xentrace, arm, hvm
Date: Sat, 08 Feb 2014 16:53:30 +0000	[thread overview]
Message-ID: <52F6610A.1060401@linaro.org> (raw)
In-Reply-To: <CAE4oM6wFyRMXw==kkHFr0Gy7JS9=GZQyJ5grHQRr82CdT+gbOw@mail.gmail.com>



On 08/02/14 15:51, Pavlo Suikov wrote:
> Hi,

Hi Pavlo,

>>
>> >  > To support xentrace on ARM, we will need at least:
>> >
>> > I would readily do that if you give me some directions on where to look
>> > at, or a high-level explanation of:
>> >
>> >  > - to replace rcu_lock_domain_by_any_id() by a a similar function
>> >
>> > What semantics should this function have?
>>
>> I would copy in part get_pg_owner (arch/x86/mm/mm.c) in the ARM code.
>> The check "unlikely(paging_mode_translate(curr))" will always fail on ARM.
>
>> Probably best just todig in and ask questions as issues arise.
>
> After making a quick workaround to rcu_lock DOMAIN_XEN on arm (in the
> quite same manner it is done in x86) I've faced different problem.
> Specifically, p2m_lookup for an address in the xen restricted heap fails
> on the very first map call: p2m_map_first returns zero page due to both
> p2m->first_level and p2m_first_level_index(addr) equal to zero. As far
> as I understand xen simply does not know how to make p2m translation for
> it's own restricted heap on arm. Am I right?

For DOMID_XEN, the p2m is not initialized. When xentrace requests to map 
a page by directly giving the mfn (machine frame number), so there is no 
need of translation.

I would either add a specific case for DOMID_XEN in get_page_from_gfn or 
p2m_lookup.

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-02-08 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 17:32 xentrace, arm, hvm Pavlo Suikov
2014-02-03 20:32 ` Julien Grall
2014-02-04 12:39   ` Pavlo Suikov
2014-02-04 13:31     ` Julien Grall
2014-02-04 13:57       ` Ian Campbell
2014-02-08 15:51         ` Pavlo Suikov
2014-02-08 16:53           ` Julien Grall [this message]
2014-02-08 21:04           ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F6610A.1060401@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=pavlo.suikov@globallogic.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).