* 4.4.0-rc3 tagged @ 2014-01-31 12:14 Ian Jackson 2014-01-31 23:07 ` Don Slutz 0 siblings, 1 reply; 23+ messages in thread From: Ian Jackson @ 2014-01-31 12:14 UTC (permalink / raw) To: xen-devel We've just tagged 4.4.0-rc3, please test and report bugs. The tarball can be downloaded here: http://bits.xensource.com/oss-xen/release/4.4.0-rc3/xen-4.4.0-rc3.tar.gz Ian. (PS: Due to an oversight by me, the version number in the xen/Makefile is still "-rc2", so the message printed at startup by 4.4.0-rc3 claims that it's "4.4.0-rc2". Sorry about that.) ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-01-31 12:14 4.4.0-rc3 tagged Ian Jackson @ 2014-01-31 23:07 ` Don Slutz 2014-02-03 11:48 ` Ian Jackson 0 siblings, 1 reply; 23+ messages in thread From: Don Slutz @ 2014-01-31 23:07 UTC (permalink / raw) To: Ian Jackson, xen-devel On CentOS release 5.10 (Final) I hit QEMU bug #1257099: lt LINK libcacard.la /usr/bin/ld: libcacard/.libs/vcard.o: relocation R_X86_64_PC32 against `vcard_buffer_response_delete' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value collect2: ld returned 1 exit status make[3]: *** [libcacard.la] Error 1 make[3]: Leaving directory `/home/don/xen-4.4.0-rc3/tools/qemu-xen-dir' make[2]: *** [subdir-all-qemu-xen-dir] Error 2 make[2]: Leaving directory `/home/don/xen-4.4.0-rc3/tools' make[1]: *** [subdirs-install] Error 2 make[1]: Leaving directory `/home/don/xen-4.4.0-rc3/tools' make: *** [install-tools] Error 2 See https://bugs.launchpad.net/bugs/1257099 Based on https://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01826.htmlhttps://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01826.html it should make it into QEMU at some point. So now I either change tools/Makefile to include "--disable-smartcard-nss" for QEMU or use the patch: From c6ce0e32c09979ba5d7d0d416293fbc700372c61 Mon Sep 17 00:00:00 2001 From: Don Slutz <dslutz@verizon.com> Date: Fri, 31 Jan 2014 20:59:28 +0000 Subject: [PATCH] tools/Makefile: Change QEMU_XEN_ENABLE_DEBUG to an add to allow for additional QEMU options. This is currently needed to work around QEMU bug #1257099 on CentOS 5.10 I.E. via export QEMU_XEN_ENABLE_DEBUG=--disable-smartcard-nss Signed-off-by: Don Slutz <dslutz@verizon.com> --- tools/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index 00c69ee..a3b8a7e 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -174,9 +174,7 @@ qemu-xen-dir-force-update: fi ifeq ($(debug),y) -QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr -else -QEMU_XEN_ENABLE_DEBUG := +QEMU_XEN_ENABLE_DEBUG += --enable-debug --enable-trace-backend=stderr endif subdir-all-qemu-xen-dir: qemu-xen-dir-find -- 1.8.2.1 and also: export QEMU_XEN_ENABLE_DEBUG=--disable-smartcard-nss This gets me to: Parsing /home/don/xen/tools/ocaml/libs/xl/../../../../tools/libxl/libxl_types.idl MLDEP make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' make[7]: Entering directory `/home/don/xen/tools/ocaml/libs/xl' MLC xenlight.cmo MLA xenlight.cma CC xenlight_stubs.o cc1: warnings being treated as errors xenlight_stubs.c: In function 'Defbool_val': xenlight_stubs.c:344: warning: implicit declaration of function 'CAMLreturnT' xenlight_stubs.c:344: error: expected expression before 'libxl_defbool' xenlight_stubs.c: In function 'String_option_val': xenlight_stubs.c:379: error: expected expression before 'char' xenlight_stubs.c: In function 'aohow_val': xenlight_stubs.c:440: error: expected expression before 'libxl_asyncop_how' make[7]: *** [xenlight_stubs.o] Error 1 make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' make[6]: *** [subdir-install-xl] Error 2 make[6]: Leaving directory `/home/don/xen/tools/ocaml/libs' make[5]: *** [subdirs-install] Error 2 make[5]: Leaving directory `/home/don/xen/tools/ocaml/libs' make[4]: *** [subdir-install-libs] Error 2 make[4]: Leaving directory `/home/don/xen/tools/ocaml' make[3]: *** [subdirs-install] Error 2 make[3]: Leaving directory `/home/don/xen/tools/ocaml' make[2]: *** [subdir-install-ocaml] Error 2 make[2]: Leaving directory `/home/don/xen/tools' make[1]: *** [subdirs-install] Error 2 make[1]: Leaving directory `/home/don/xen/tools' make: *** [install-tools] Error 2 Not sure how to work around this. -Don Slutz On 01/31/14 07:14, Ian Jackson wrote: > We've just tagged 4.4.0-rc3, please test and report bugs. > > The tarball can be downloaded here: > > http://bits.xensource.com/oss-xen/release/4.4.0-rc3/xen-4.4.0-rc3.tar.gz > > Ian. > > (PS: Due to an oversight by me, the version number in the xen/Makefile > is still "-rc2", so the message printed at startup by 4.4.0-rc3 claims > that it's "4.4.0-rc2". Sorry about that.) > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-01-31 23:07 ` Don Slutz @ 2014-02-03 11:48 ` Ian Jackson 2014-02-03 12:01 ` Stefano Stabellini 0 siblings, 1 reply; 23+ messages in thread From: Ian Jackson @ 2014-02-03 11:48 UTC (permalink / raw) To: Don Slutz; +Cc: xen-devel, Stefano Stabellini Don Slutz writes ("Re: [Xen-devel] 4.4.0-rc3 tagged"): > On CentOS release 5.10 (Final) I hit QEMU bug #1257099: CC'ing Stefano, who is in charge of the Xen qemu-upstream tree. Thanks, Ian. > lt LINK libcacard.la > /usr/bin/ld: libcacard/.libs/vcard.o: relocation R_X86_64_PC32 against `vcard_buffer_response_delete' can not be used when making a shared object; recompile with -fPIC > /usr/bin/ld: final link failed: Bad value > collect2: ld returned 1 exit status > make[3]: *** [libcacard.la] Error 1 > make[3]: Leaving directory `/home/don/xen-4.4.0-rc3/tools/qemu-xen-dir' > make[2]: *** [subdir-all-qemu-xen-dir] Error 2 > make[2]: Leaving directory `/home/don/xen-4.4.0-rc3/tools' > make[1]: *** [subdirs-install] Error 2 > make[1]: Leaving directory `/home/don/xen-4.4.0-rc3/tools' > make: *** [install-tools] Error 2 > > See https://bugs.launchpad.net/bugs/1257099 > > Based on > > https://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01826.htmlhttps://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01826.html > > it should make it into QEMU at some point. > > So now I either change tools/Makefile to include "--disable-smartcard-nss" for QEMU or use the patch: > > > From c6ce0e32c09979ba5d7d0d416293fbc700372c61 Mon Sep 17 00:00:00 2001 > From: Don Slutz <dslutz@verizon.com> > Date: Fri, 31 Jan 2014 20:59:28 +0000 > Subject: [PATCH] tools/Makefile: Change QEMU_XEN_ENABLE_DEBUG to an add to > allow for additional QEMU options. > > This is currently needed to work around QEMU bug #1257099 on CentOS 5.10 > > I.E. via > > export QEMU_XEN_ENABLE_DEBUG=--disable-smartcard-nss > > Signed-off-by: Don Slutz <dslutz@verizon.com> > --- > tools/Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/Makefile b/tools/Makefile > index 00c69ee..a3b8a7e 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -174,9 +174,7 @@ qemu-xen-dir-force-update: > fi > > ifeq ($(debug),y) > -QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr > -else > -QEMU_XEN_ENABLE_DEBUG := > +QEMU_XEN_ENABLE_DEBUG += --enable-debug --enable-trace-backend=stderr > endif > > subdir-all-qemu-xen-dir: qemu-xen-dir-find > -- > 1.8.2.1 > > > and also: > > export QEMU_XEN_ENABLE_DEBUG=--disable-smartcard-nss > > > This gets me to: > > Parsing /home/don/xen/tools/ocaml/libs/xl/../../../../tools/libxl/libxl_types.idl > MLDEP > make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' > make[7]: Entering directory `/home/don/xen/tools/ocaml/libs/xl' > MLC xenlight.cmo > MLA xenlight.cma > CC xenlight_stubs.o > cc1: warnings being treated as errors > xenlight_stubs.c: In function 'Defbool_val': > xenlight_stubs.c:344: warning: implicit declaration of function 'CAMLreturnT' > xenlight_stubs.c:344: error: expected expression before 'libxl_defbool' > xenlight_stubs.c: In function 'String_option_val': > xenlight_stubs.c:379: error: expected expression before 'char' > xenlight_stubs.c: In function 'aohow_val': > xenlight_stubs.c:440: error: expected expression before 'libxl_asyncop_how' > make[7]: *** [xenlight_stubs.o] Error 1 > make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' > make[6]: *** [subdir-install-xl] Error 2 > make[6]: Leaving directory `/home/don/xen/tools/ocaml/libs' > make[5]: *** [subdirs-install] Error 2 > make[5]: Leaving directory `/home/don/xen/tools/ocaml/libs' > make[4]: *** [subdir-install-libs] Error 2 > make[4]: Leaving directory `/home/don/xen/tools/ocaml' > make[3]: *** [subdirs-install] Error 2 > make[3]: Leaving directory `/home/don/xen/tools/ocaml' > make[2]: *** [subdir-install-ocaml] Error 2 > make[2]: Leaving directory `/home/don/xen/tools' > make[1]: *** [subdirs-install] Error 2 > make[1]: Leaving directory `/home/don/xen/tools' > make: *** [install-tools] Error 2 > > > Not sure how to work around this. > -Don Slutz > > > > On 01/31/14 07:14, Ian Jackson wrote: > > We've just tagged 4.4.0-rc3, please test and report bugs. > > > > The tarball can be downloaded here: > > > > http://bits.xensource.com/oss-xen/release/4.4.0-rc3/xen-4.4.0-rc3.tar.gz > > > > Ian. > > > > (PS: Due to an oversight by me, the version number in the xen/Makefile > > is still "-rc2", so the message printed at startup by 4.4.0-rc3 claims > > that it's "4.4.0-rc2". Sorry about that.) > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-03 11:48 ` Ian Jackson @ 2014-02-03 12:01 ` Stefano Stabellini 2014-02-07 0:15 ` Don Slutz 0 siblings, 1 reply; 23+ messages in thread From: Stefano Stabellini @ 2014-02-03 12:01 UTC (permalink / raw) To: Ian Jackson; +Cc: xen-devel, Don Slutz, Stefano Stabellini On Mon, 3 Feb 2014, Ian Jackson wrote: > Don Slutz writes ("Re: [Xen-devel] 4.4.0-rc3 tagged"): > > On CentOS release 5.10 (Final) I hit QEMU bug #1257099: > > CC'ing Stefano, who is in charge of the Xen qemu-upstream tree. This is the bug that you fixed with the patch linked below, but it looks like the patch never made it upstream. Let me ping Paolo on this. > Thanks, > Ian. > > > lt LINK libcacard.la > > /usr/bin/ld: libcacard/.libs/vcard.o: relocation R_X86_64_PC32 against `vcard_buffer_response_delete' can not be used when making a shared object; recompile with -fPIC > > /usr/bin/ld: final link failed: Bad value > > collect2: ld returned 1 exit status > > make[3]: *** [libcacard.la] Error 1 > > make[3]: Leaving directory `/home/don/xen-4.4.0-rc3/tools/qemu-xen-dir' > > make[2]: *** [subdir-all-qemu-xen-dir] Error 2 > > make[2]: Leaving directory `/home/don/xen-4.4.0-rc3/tools' > > make[1]: *** [subdirs-install] Error 2 > > make[1]: Leaving directory `/home/don/xen-4.4.0-rc3/tools' > > make: *** [install-tools] Error 2 > > > > See https://bugs.launchpad.net/bugs/1257099 > > > > Based on > > > > https://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01826.htmlhttps://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01826.html > > > > it should make it into QEMU at some point. > > > > So now I either change tools/Makefile to include "--disable-smartcard-nss" for QEMU or use the patch: > > > > > > From c6ce0e32c09979ba5d7d0d416293fbc700372c61 Mon Sep 17 00:00:00 2001 > > From: Don Slutz <dslutz@verizon.com> > > Date: Fri, 31 Jan 2014 20:59:28 +0000 > > Subject: [PATCH] tools/Makefile: Change QEMU_XEN_ENABLE_DEBUG to an add to > > allow for additional QEMU options. > > > > This is currently needed to work around QEMU bug #1257099 on CentOS 5.10 > > > > I.E. via > > > > export QEMU_XEN_ENABLE_DEBUG=--disable-smartcard-nss > > > > Signed-off-by: Don Slutz <dslutz@verizon.com> > > --- > > tools/Makefile | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/tools/Makefile b/tools/Makefile > > index 00c69ee..a3b8a7e 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -174,9 +174,7 @@ qemu-xen-dir-force-update: > > fi > > > > ifeq ($(debug),y) > > -QEMU_XEN_ENABLE_DEBUG := --enable-debug --enable-trace-backend=stderr > > -else > > -QEMU_XEN_ENABLE_DEBUG := > > +QEMU_XEN_ENABLE_DEBUG += --enable-debug --enable-trace-backend=stderr > > endif > > > > subdir-all-qemu-xen-dir: qemu-xen-dir-find > > -- > > 1.8.2.1 > > > > > > and also: > > > > export QEMU_XEN_ENABLE_DEBUG=--disable-smartcard-nss > > > > > > This gets me to: > > > > Parsing /home/don/xen/tools/ocaml/libs/xl/../../../../tools/libxl/libxl_types.idl > > MLDEP > > make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' > > make[7]: Entering directory `/home/don/xen/tools/ocaml/libs/xl' > > MLC xenlight.cmo > > MLA xenlight.cma > > CC xenlight_stubs.o > > cc1: warnings being treated as errors > > xenlight_stubs.c: In function 'Defbool_val': > > xenlight_stubs.c:344: warning: implicit declaration of function 'CAMLreturnT' > > xenlight_stubs.c:344: error: expected expression before 'libxl_defbool' > > xenlight_stubs.c: In function 'String_option_val': > > xenlight_stubs.c:379: error: expected expression before 'char' > > xenlight_stubs.c: In function 'aohow_val': > > xenlight_stubs.c:440: error: expected expression before 'libxl_asyncop_how' > > make[7]: *** [xenlight_stubs.o] Error 1 > > make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' > > make[6]: *** [subdir-install-xl] Error 2 > > make[6]: Leaving directory `/home/don/xen/tools/ocaml/libs' > > make[5]: *** [subdirs-install] Error 2 > > make[5]: Leaving directory `/home/don/xen/tools/ocaml/libs' > > make[4]: *** [subdir-install-libs] Error 2 > > make[4]: Leaving directory `/home/don/xen/tools/ocaml' > > make[3]: *** [subdirs-install] Error 2 > > make[3]: Leaving directory `/home/don/xen/tools/ocaml' > > make[2]: *** [subdir-install-ocaml] Error 2 > > make[2]: Leaving directory `/home/don/xen/tools' > > make[1]: *** [subdirs-install] Error 2 > > make[1]: Leaving directory `/home/don/xen/tools' > > make: *** [install-tools] Error 2 > > > > > > Not sure how to work around this. > > -Don Slutz > > > > > > > > On 01/31/14 07:14, Ian Jackson wrote: > > > We've just tagged 4.4.0-rc3, please test and report bugs. > > > > > > The tarball can be downloaded here: > > > > > > http://bits.xensource.com/oss-xen/release/4.4.0-rc3/xen-4.4.0-rc3.tar.gz > > > > > > Ian. > > > > > > (PS: Due to an oversight by me, the version number in the xen/Makefile > > > is still "-rc2", so the message printed at startup by 4.4.0-rc3 claims > > > that it's "4.4.0-rc2". Sorry about that.) > > > > > > _______________________________________________ > > > Xen-devel mailing list > > > Xen-devel@lists.xen.org > > > http://lists.xen.org/xen-devel > > > ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-03 12:01 ` Stefano Stabellini @ 2014-02-07 0:15 ` Don Slutz 2014-02-07 10:05 ` Ian Campbell 0 siblings, 1 reply; 23+ messages in thread From: Don Slutz @ 2014-02-07 0:15 UTC (permalink / raw) To: Ian Jackson; +Cc: xen-devel, Don Slutz, Stefano Stabellini On 02/03/14 07:01, Stefano Stabellini wrote: > This gets me to: > > > > > >Parsing/home/don/xen/tools/ocaml/libs/xl/../../../../tools/libxl/libxl_types.idl > > > MLDEP > > >make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' > > >make[7]: Entering directory `/home/don/xen/tools/ocaml/libs/xl' > > > MLC xenlight.cmo > > > MLA xenlight.cma > > > CC xenlight_stubs.o > > >cc1: warnings being treated as errors > > >xenlight_stubs.c: In function 'Defbool_val': > > >xenlight_stubs.c:344: warning: implicit declaration of function 'CAMLreturnT' > > >xenlight_stubs.c:344: error: expected expression before 'libxl_defbool' > > >xenlight_stubs.c: In function 'String_option_val': > > >xenlight_stubs.c:379: error: expected expression before 'char' > > >xenlight_stubs.c: In function 'aohow_val': > > >xenlight_stubs.c:440: error: expected expression before 'libxl_asyncop_how' > > >make[7]: *** [xenlight_stubs.o] Error 1 > > >make[7]: Leaving directory `/home/don/xen/tools/ocaml/libs/xl' > > >make[6]: *** [subdir-install-xl] Error 2 > > >make[6]: Leaving directory `/home/don/xen/tools/ocaml/libs' > > >make[5]: *** [subdirs-install] Error 2 > > >make[5]: Leaving directory `/home/don/xen/tools/ocaml/libs' > > >make[4]: *** [subdir-install-libs] Error 2 > > >make[4]: Leaving directory `/home/don/xen/tools/ocaml' > > >make[3]: *** [subdirs-install] Error 2 > > >make[3]: Leaving directory `/home/don/xen/tools/ocaml' > > >make[2]: *** [subdir-install-ocaml] Error 2 > > >make[2]: Leaving directory `/home/don/xen/tools' > > >make[1]: *** [subdirs-install] Error 2 > > >make[1]: Leaving directory `/home/don/xen/tools' > > >make: *** [install-tools] Error 2 > > > > > > > > >Not sure how to work around this. > > > -Don Slutz Any idea on what to do about ocaml issue? -Don Slutz ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-07 0:15 ` Don Slutz @ 2014-02-07 10:05 ` Ian Campbell 2014-02-07 16:22 ` Don Slutz 0 siblings, 1 reply; 23+ messages in thread From: Ian Campbell @ 2014-02-07 10:05 UTC (permalink / raw) To: Don Slutz; +Cc: xen-devel, Ian Jackson, Rob Hoes, Stefano Stabellini On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: > > > >cc1: warnings being treated as errors > > > >xenlight_stubs.c: In function 'Defbool_val': > > > >xenlight_stubs.c:344: warning: implicit declaration of function 'CAMLreturnT' > > > >xenlight_stubs.c:344: error: expected expression before 'libxl_defbool' > > > >xenlight_stubs.c: In function 'String_option_val': > > > >xenlight_stubs.c:379: error: expected expression before 'char' > > > >xenlight_stubs.c: In function 'aohow_val': > > > >xenlight_stubs.c:440: error: expected expression before 'libxl_asyncop_how' > > Any idea on what to do about ocaml issue? My guess is that your ocaml is too old and doesn't supply CAMLreturnT. What version do you have? Ian. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-07 10:05 ` Ian Campbell @ 2014-02-07 16:22 ` Don Slutz 2014-02-07 16:29 ` Andrew Cooper 0 siblings, 1 reply; 23+ messages in thread From: Don Slutz @ 2014-02-07 16:22 UTC (permalink / raw) To: Ian Campbell Cc: xen-devel, Ian Jackson, Rob Hoes, Don Slutz, Stefano Stabellini On 02/07/14 05:05, Ian Campbell wrote: > On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>> cc1: warnings being treated as errors >>>>> xenlight_stubs.c: In function 'Defbool_val': >>>>> xenlight_stubs.c:344: warning: implicit declaration of function 'CAMLreturnT' >>>>> xenlight_stubs.c:344: error: expected expression before 'libxl_defbool' >>>>> xenlight_stubs.c: In function 'String_option_val': >>>>> xenlight_stubs.c:379: error: expected expression before 'char' >>>>> xenlight_stubs.c: In function 'aohow_val': >>>>> xenlight_stubs.c:440: error: expected expression before 'libxl_asyncop_how' >> Any idea on what to do about ocaml issue? > My guess is that your ocaml is too old and doesn't supply CAMLreturnT. > What version do you have? > > Ian. > dcs-xen-53:~>ocaml -version The Objective Caml toplevel, version 3.09.3 -Don Slutz ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-07 16:22 ` Don Slutz @ 2014-02-07 16:29 ` Andrew Cooper 2014-02-10 9:55 ` Ian Campbell 0 siblings, 1 reply; 23+ messages in thread From: Andrew Cooper @ 2014-02-07 16:29 UTC (permalink / raw) To: Don Slutz Cc: xen-devel, Stefano Stabellini, Ian Jackson, Ian Campbell, Rob Hoes On 07/02/14 16:22, Don Slutz wrote: > On 02/07/14 05:05, Ian Campbell wrote: >> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>>> cc1: warnings being treated as errors >>>>>> xenlight_stubs.c: In function 'Defbool_val': >>>>>> xenlight_stubs.c:344: warning: implicit declaration of function >>>>>> 'CAMLreturnT' >>>>>> xenlight_stubs.c:344: error: expected expression before >>>>>> 'libxl_defbool' >>>>>> xenlight_stubs.c: In function 'String_option_val': >>>>>> xenlight_stubs.c:379: error: expected expression before 'char' >>>>>> xenlight_stubs.c: In function 'aohow_val': >>>>>> xenlight_stubs.c:440: error: expected expression before >>>>>> 'libxl_asyncop_how' >>> Any idea on what to do about ocaml issue? >> My guess is that your ocaml is too old and doesn't supply CAMLreturnT. >> What version do you have? >> >> Ian. >> > dcs-xen-53:~>ocaml -version > The Objective Caml toplevel, version 3.09.3 > > -Don Slutz > Which, according to google, was introduced in 3.09.4 I think the ./configure script needs a min version check. Applying the top macro from http://docs.camlcity.org/docs/godisrc/oasis-ocaml-fd-1.1.1.tar.gz/ocaml-fd-1.1.1/lib/fd_stubs.c as a compatibility hack might also be a good idea. ~Andrew ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-07 16:29 ` Andrew Cooper @ 2014-02-10 9:55 ` Ian Campbell 2014-02-10 10:59 ` Roger Pau Monné 0 siblings, 1 reply; 23+ messages in thread From: Ian Campbell @ 2014-02-10 9:55 UTC (permalink / raw) To: Andrew Cooper Cc: Stefano Stabellini, Ian Jackson, Rob Hoes, Don Slutz, xen-devel, Roger Pau Monne On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: > On 07/02/14 16:22, Don Slutz wrote: > > On 02/07/14 05:05, Ian Campbell wrote: > >> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: > >>>>>> cc1: warnings being treated as errors > >>>>>> xenlight_stubs.c: In function 'Defbool_val': > >>>>>> xenlight_stubs.c:344: warning: implicit declaration of function > >>>>>> 'CAMLreturnT' > >>>>>> xenlight_stubs.c:344: error: expected expression before > >>>>>> 'libxl_defbool' > >>>>>> xenlight_stubs.c: In function 'String_option_val': > >>>>>> xenlight_stubs.c:379: error: expected expression before 'char' > >>>>>> xenlight_stubs.c: In function 'aohow_val': > >>>>>> xenlight_stubs.c:440: error: expected expression before > >>>>>> 'libxl_asyncop_how' > >>> Any idea on what to do about ocaml issue? > >> My guess is that your ocaml is too old and doesn't supply CAMLreturnT. > >> What version do you have? > >> > >> Ian. > >> > > dcs-xen-53:~>ocaml -version > > The Objective Caml toplevel, version 3.09.3 > > > > -Don Slutz > > > > Which, according to google, was introduced in 3.09.4 > > I think the ./configure script needs a min version check. Yes, I think so too. Rob, could you advise on a suitable minimum and perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. Also CCing Roger who added the ocaml autoconf stuff. > Applying the top macro from > http://docs.camlcity.org/docs/godisrc/oasis-ocaml-fd-1.1.1.tar.gz/ocaml-fd-1.1.1/lib/fd_stubs.c > as a compatibility hack might also be a good idea. Not a bad idea. Ian. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 9:55 ` Ian Campbell @ 2014-02-10 10:59 ` Roger Pau Monné 2014-02-10 18:48 ` Don Slutz 2014-03-12 13:54 ` Ian Campbell 0 siblings, 2 replies; 23+ messages in thread From: Roger Pau Monné @ 2014-02-10 10:59 UTC (permalink / raw) To: Ian Campbell, Andrew Cooper Cc: xen-devel, Ian Jackson, Rob Hoes, Don Slutz, Stefano Stabellini On 10/02/14 10:55, Ian Campbell wrote: > On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: >> On 07/02/14 16:22, Don Slutz wrote: >>> On 02/07/14 05:05, Ian Campbell wrote: >>>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>>>>> cc1: warnings being treated as errors >>>>>>>> xenlight_stubs.c: In function 'Defbool_val': >>>>>>>> xenlight_stubs.c:344: warning: implicit declaration of function >>>>>>>> 'CAMLreturnT' >>>>>>>> xenlight_stubs.c:344: error: expected expression before >>>>>>>> 'libxl_defbool' >>>>>>>> xenlight_stubs.c: In function 'String_option_val': >>>>>>>> xenlight_stubs.c:379: error: expected expression before 'char' >>>>>>>> xenlight_stubs.c: In function 'aohow_val': >>>>>>>> xenlight_stubs.c:440: error: expected expression before >>>>>>>> 'libxl_asyncop_how' >>>>> Any idea on what to do about ocaml issue? >>>> My guess is that your ocaml is too old and doesn't supply CAMLreturnT. >>>> What version do you have? >>>> >>>> Ian. >>>> >>> dcs-xen-53:~>ocaml -version >>> The Objective Caml toplevel, version 3.09.3 >>> >>> -Don Slutz >>> >> >> Which, according to google, was introduced in 3.09.4 >> >> I think the ./configure script needs a min version check. > > Yes, I think so too. Rob, could you advise on a suitable minimum and > perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. > > Also CCing Roger who added the ocaml autoconf stuff. The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. Here is an untested patch for our configure script to check for the minimum required OCaml version (3.09.3): (remember to re-generate the configure script after applying) --- commit e49609cc7b93c2633cf5a49206cb29d6bdd612be Author: Roger Pau Monne <roger.pau@citrix.com> Date: Mon Feb 10 11:54:13 2014 +0100 tools: check OCaml version is at least 3.09.3 Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> diff --git a/tools/configure.ac b/tools/configure.ac index 0754f0e..6d1e2ee 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -161,6 +161,12 @@ AS_IF([test "x$ocamltools" = "xy"], [ AS_IF([test "x$enable_ocamltools" = "xyes"], [ AC_MSG_ERROR([Ocaml tools enabled, but unable to find Ocaml])]) ocamltools="n" + ], [ + AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.4], [ + AS_IF([test "x$enable_ocamltools" = "xyes"], [ + AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not supported])]) + ocamltools="n" + ]) ]) ]) AS_IF([test "x$xsmpolicy" = "xy"], [ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 10:59 ` Roger Pau Monné @ 2014-02-10 18:48 ` Don Slutz 2014-02-10 18:59 ` Roger Pau Monné 2014-03-12 13:54 ` Ian Campbell 1 sibling, 1 reply; 23+ messages in thread From: Don Slutz @ 2014-02-10 18:48 UTC (permalink / raw) To: Roger Pau Monné, Ian Campbell, Andrew Cooper Cc: xen-devel, Ian Jackson, Rob Hoes, Don Slutz, Stefano Stabellini On 02/10/14 05:59, Roger Pau Monné wrote: > On 10/02/14 10:55, Ian Campbell wrote: >> On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: >>> On 07/02/14 16:22, Don Slutz wrote: >>>> On 02/07/14 05:05, Ian Campbell wrote: >>>>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>>>>>> cc1: warnings being treated as errors >>>>>>>>> xenlight_stubs.c: In function 'Defbool_val': >>>>>>>>> xenlight_stubs.c:344: warning: implicit declaration of function >>>>>>>>> 'CAMLreturnT' >>>>>>>>> xenlight_stubs.c:344: error: expected expression before >>>>>>>>> 'libxl_defbool' >>>>>>>>> xenlight_stubs.c: In function 'String_option_val': >>>>>>>>> xenlight_stubs.c:379: error: expected expression before 'char' >>>>>>>>> xenlight_stubs.c: In function 'aohow_val': >>>>>>>>> xenlight_stubs.c:440: error: expected expression before >>>>>>>>> 'libxl_asyncop_how' >>>>>> Any idea on what to do about ocaml issue? >>>>> My guess is that your ocaml is too old and doesn't supply CAMLreturnT. >>>>> What version do you have? >>>>> >>>>> Ian. >>>>> >>>> dcs-xen-53:~>ocaml -version >>>> The Objective Caml toplevel, version 3.09.3 >>>> >>>> -Don Slutz >>>> >>> Which, according to google, was introduced in 3.09.4 >>> >>> I think the ./configure script needs a min version check. >> Yes, I think so too. Rob, could you advise on a suitable minimum and >> perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. >> >> Also CCing Roger who added the ocaml autoconf stuff. > The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. > Here is an untested patch for our configure script to check for the > minimum required OCaml version (3.09.3): > > (remember to re-generate the configure script after applying) Not sure if the older Autoconf (2.68) is at fault, but I get: dcs-xen-54:~/xen/tools>autoconf configure.ac >configure configure.ac:14: error: possibly undefined macro: AS_IF If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR and the generated script is bad: if test "x$OCAMLC" = "xno" || test "x$OCAMLFIND" = "xno"; then : if test "x$enable_ocamltools" = "xyes"; then : as_fn_error $? "Ocaml tools enabled, but unable to find Ocaml" "$LINENO" 5 fi ocamltools="n" else AX_COMPARE_VERSION($OCAMLVERSION, lt, 3.09.4, AS_IF([test "x$enable_ocamltools" = "xyes"], [ AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not supported])]) ocamltools="n" ) fi fi -Don Slutz > --- > commit e49609cc7b93c2633cf5a49206cb29d6bdd612be > Author: Roger Pau Monne <roger.pau@citrix.com> > Date: Mon Feb 10 11:54:13 2014 +0100 > > tools: check OCaml version is at least 3.09.3 > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > diff --git a/tools/configure.ac b/tools/configure.ac > index 0754f0e..6d1e2ee 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -161,6 +161,12 @@ AS_IF([test "x$ocamltools" = "xy"], [ > AS_IF([test "x$enable_ocamltools" = "xyes"], [ > AC_MSG_ERROR([Ocaml tools enabled, but unable to find Ocaml])]) > ocamltools="n" > + ], [ > + AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.4], [ > + AS_IF([test "x$enable_ocamltools" = "xyes"], [ > + AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not supported])]) > + ocamltools="n" > + ]) > ]) > ]) > AS_IF([test "x$xsmpolicy" = "xy"], [ > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 18:48 ` Don Slutz @ 2014-02-10 18:59 ` Roger Pau Monné 2014-02-10 19:23 ` Don Slutz 0 siblings, 1 reply; 23+ messages in thread From: Roger Pau Monné @ 2014-02-10 18:59 UTC (permalink / raw) To: Don Slutz, Ian Campbell, Andrew Cooper Cc: xen-devel, Ian Jackson, Rob Hoes, Stefano Stabellini On 10/02/14 19:48, Don Slutz wrote: > On 02/10/14 05:59, Roger Pau Monné wrote: >> On 10/02/14 10:55, Ian Campbell wrote: >>> On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: >>>> On 07/02/14 16:22, Don Slutz wrote: >>>>> On 02/07/14 05:05, Ian Campbell wrote: >>>>>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>>>>>>> cc1: warnings being treated as errors >>>>>>>>>> xenlight_stubs.c: In function 'Defbool_val': >>>>>>>>>> xenlight_stubs.c:344: warning: implicit declaration of function >>>>>>>>>> 'CAMLreturnT' >>>>>>>>>> xenlight_stubs.c:344: error: expected expression before >>>>>>>>>> 'libxl_defbool' >>>>>>>>>> xenlight_stubs.c: In function 'String_option_val': >>>>>>>>>> xenlight_stubs.c:379: error: expected expression before 'char' >>>>>>>>>> xenlight_stubs.c: In function 'aohow_val': >>>>>>>>>> xenlight_stubs.c:440: error: expected expression before >>>>>>>>>> 'libxl_asyncop_how' >>>>>>> Any idea on what to do about ocaml issue? >>>>>> My guess is that your ocaml is too old and doesn't supply >>>>>> CAMLreturnT. >>>>>> What version do you have? >>>>>> >>>>>> Ian. >>>>>> >>>>> dcs-xen-53:~>ocaml -version >>>>> The Objective Caml toplevel, version 3.09.3 >>>>> >>>>> -Don Slutz >>>>> >>>> Which, according to google, was introduced in 3.09.4 >>>> >>>> I think the ./configure script needs a min version check. >>> Yes, I think so too. Rob, could you advise on a suitable minimum and >>> perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. >>> >>> Also CCing Roger who added the ocaml autoconf stuff. >> The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. >> Here is an untested patch for our configure script to check for the >> minimum required OCaml version (3.09.3): >> >> (remember to re-generate the configure script after applying) > > Not sure if the older Autoconf (2.68) is at fault, but I get: > > dcs-xen-54:~/xen/tools>autoconf configure.ac >configure > configure.ac:14: error: possibly undefined macro: AS_IF > If this token and others are legitimate, please use m4_pattern_allow. > See the Autoconf documentation. > configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR On Debian systems you need the autoconf-archive package which provides the AX_COMPARE_VERSION macro, and then you also need to run aclocal before autoconf. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 18:59 ` Roger Pau Monné @ 2014-02-10 19:23 ` Don Slutz 2014-02-10 19:33 ` Roger Pau Monné 0 siblings, 1 reply; 23+ messages in thread From: Don Slutz @ 2014-02-10 19:23 UTC (permalink / raw) To: Roger Pau Monné, Don Slutz, Ian Campbell, Andrew Cooper Cc: xen-devel, Ian Jackson, Rob Hoes, Stefano Stabellini On 02/10/14 13:59, Roger Pau Monné wrote: > On 10/02/14 19:48, Don Slutz wrote: >> On 02/10/14 05:59, Roger Pau Monné wrote: >>> On 10/02/14 10:55, Ian Campbell wrote: >>>> On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: >>>>> On 07/02/14 16:22, Don Slutz wrote: >>>>>> On 02/07/14 05:05, Ian Campbell wrote: >>>>>>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>>> [snip] >>>>> Which, according to google, was introduced in 3.09.4 >>>>> >>>>> I think the ./configure script needs a min version check. >>>> Yes, I think so too. Rob, could you advise on a suitable minimum and >>>> perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. >>>> >>>> Also CCing Roger who added the ocaml autoconf stuff. >>> The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. >>> Here is an untested patch for our configure script to check for the >>> minimum required OCaml version (3.09.3): >>> >>> (remember to re-generate the configure script after applying) >> Not sure if the older Autoconf (2.68) is at fault, but I get: >> >> dcs-xen-54:~/xen/tools>autoconf configure.ac >configure >> configure.ac:14: error: possibly undefined macro: AS_IF >> If this token and others are legitimate, please use m4_pattern_allow. >> See the Autoconf documentation. >> configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR > On Debian systems you need the autoconf-archive package which provides > the AX_COMPARE_VERSION macro, and then you also need to run aclocal > before autoconf. > > Roger. > The CentOS 5.10 system has a too old autoconf to do the rebuild, So I went to a Fedora 17 system. It does have autoconf-archive package, nut that make no difference: Installed: autoconf-archive.noarch 0:2012.09.08-1.fc17 Complete! dcs-xen-54:~/xen/tools>autoconf configure.ac >configure configure.ac:14: error: possibly undefined macro: AS_IF If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR And the same bad code is still generated: if test "x$OCAMLC" = "xno" || test "x$OCAMLFIND" = "xno"; then : if test "x$enable_ocamltools" = "xyes"; then : as_fn_error $? "Ocaml tools enabled, but unable to find Ocaml" "$LINENO" 5 fi ocamltools="n" else AX_COMPARE_VERSION($OCAMLVERSION, lt, 3.09.4, AS_IF([test "x$enable_ocamltools" = "xyes"], [ AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not supported])]) ocamltools="n" ) fi -Don Slutz _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 19:23 ` Don Slutz @ 2014-02-10 19:33 ` Roger Pau Monné 2014-02-10 23:53 ` Don Slutz 0 siblings, 1 reply; 23+ messages in thread From: Roger Pau Monné @ 2014-02-10 19:33 UTC (permalink / raw) To: Don Slutz, Ian Campbell, Andrew Cooper Cc: xen-devel, Ian Jackson, Rob Hoes, Stefano Stabellini On 10/02/14 20:23, Don Slutz wrote: > On 02/10/14 13:59, Roger Pau Monné wrote: >> On 10/02/14 19:48, Don Slutz wrote: >>> On 02/10/14 05:59, Roger Pau Monné wrote: >>>> On 10/02/14 10:55, Ian Campbell wrote: >>>>> On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: >>>>>> On 07/02/14 16:22, Don Slutz wrote: >>>>>>> On 02/07/14 05:05, Ian Campbell wrote: >>>>>>>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >>>>>>> > [snip] >>>>>> Which, according to google, was introduced in 3.09.4 >>>>>> >>>>>> I think the ./configure script needs a min version check. >>>>> Yes, I think so too. Rob, could you advise on a suitable minimum and >>>>> perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. >>>>> >>>>> Also CCing Roger who added the ocaml autoconf stuff. >>>> The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. >>>> Here is an untested patch for our configure script to check for the >>>> minimum required OCaml version (3.09.3): >>>> >>>> (remember to re-generate the configure script after applying) >>> Not sure if the older Autoconf (2.68) is at fault, but I get: >>> >>> dcs-xen-54:~/xen/tools>autoconf configure.ac >configure >>> configure.ac:14: error: possibly undefined macro: AS_IF >>> If this token and others are legitimate, please use >>> m4_pattern_allow. >>> See the Autoconf documentation. >>> configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR >> On Debian systems you need the autoconf-archive package which provides >> the AX_COMPARE_VERSION macro, and then you also need to run aclocal >> before autoconf. >> >> Roger. >> > > The CentOS 5.10 system has a too old autoconf to do the rebuild, So I > went to a Fedora 17 system. > > It does have autoconf-archive package, nut that make no difference: > > > Installed: > autoconf-archive.noarch 0:2012.09.08-1.fc17 > > Complete! > dcs-xen-54:~/xen/tools>autoconf configure.ac >configure > configure.ac:14: error: possibly undefined macro: AS_IF > If this token and others are legitimate, please use m4_pattern_allow. > See the Autoconf documentation. > configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR Did you run aclocal before autoconf? Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 19:33 ` Roger Pau Monné @ 2014-02-10 23:53 ` Don Slutz 2014-02-11 9:41 ` Ian Campbell 0 siblings, 1 reply; 23+ messages in thread From: Don Slutz @ 2014-02-10 23:53 UTC (permalink / raw) To: Roger Pau Monné, Don Slutz, Ian Campbell, Andrew Cooper Cc: xen-devel, Ian Jackson, Rob Hoes, Stefano Stabellini On 02/10/14 14:33, Roger Pau Monné wrote: > On 10/02/14 20:23, Don Slutz wrote: >> On 02/10/14 13:59, Roger Pau Monné wrote: >>> On 10/02/14 19:48, Don Slutz wrote: >>>> On 02/10/14 05:59, Roger Pau Monné wrote: >>>>> On 10/02/14 10:55, Ian Campbell wrote: >>>>>> On Fri, 2014-02-07 at 16:29 +0000, Andrew Cooper wrote: >>>>>>> On 07/02/14 16:22, Don Slutz wrote: >>>>>>>> On 02/07/14 05:05, Ian Campbell wrote: >>>>>>>>> On Thu, 2014-02-06 at 19:15 -0500, Don Slutz wrote: >> [snip] >>>>>>> Which, according to google, was introduced in 3.09.4 >>>>>>> >>>>>>> I think the ./configure script needs a min version check. >>>>>> Yes, I think so too. Rob, could you advise on a suitable minimum and >>>>>> perhaps patch tools/configure.ac and/or m4/ocaml.m4 as necessary. >>>>>> >>>>>> Also CCing Roger who added the ocaml autoconf stuff. >>>>> The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. >>>>> Here is an untested patch for our configure script to check for the >>>>> minimum required OCaml version (3.09.3): >>>>> >>>>> (remember to re-generate the configure script after applying) >>>> Not sure if the older Autoconf (2.68) is at fault, but I get: >>>> >>>> dcs-xen-54:~/xen/tools>autoconf configure.ac >configure >>>> configure.ac:14: error: possibly undefined macro: AS_IF >>>> If this token and others are legitimate, please use >>>> m4_pattern_allow. >>>> See the Autoconf documentation. >>>> configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR >>> On Debian systems you need the autoconf-archive package which provides >>> the AX_COMPARE_VERSION macro, and then you also need to run aclocal >>> before autoconf. >>> >>> Roger. >>> >> The CentOS 5.10 system has a too old autoconf to do the rebuild, So I >> went to a Fedora 17 system. >> >> It does have autoconf-archive package, nut that make no difference: >> >> >> Installed: >> autoconf-archive.noarch 0:2012.09.08-1.fc17 >> >> Complete! >> dcs-xen-54:~/xen/tools>autoconf configure.ac >configure >> configure.ac:14: error: possibly undefined macro: AS_IF >> If this token and others are legitimate, please use m4_pattern_allow. >> See the Autoconf documentation. >> configure.ac:162: error: possibly undefined macro: AC_MSG_ERROR > Did you run aclocal before autoconf? > > Thanks, Roger. > That did what was needed. And it looks to be working. However, with patch: http://lists.xen.org/archives/html/xen-devel/2014-02/msg00826.html Which looks to be going in, the version that is checked should be changed to 3.09.3 from 3.09.4. Note: The commit message does not match the code. You can add: Tested-by: Don Slutz <dslutz@verizon.com> -Don Slutz _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 23:53 ` Don Slutz @ 2014-02-11 9:41 ` Ian Campbell 2014-02-11 9:56 ` Roger Pau Monné 0 siblings, 1 reply; 23+ messages in thread From: Ian Campbell @ 2014-02-11 9:41 UTC (permalink / raw) To: Don Slutz Cc: Stefano Stabellini, Andrew Cooper, Ian Jackson, Rob Hoes, xen-devel, Roger Pau Monné On Mon, 2014-02-10 at 18:53 -0500, Don Slutz wrote: > On 02/10/14 14:33, Roger Pau Monné wrote: > > Did you run aclocal before autoconf? > That did what was needed. For future reference you can just run ./autogen.sh at the top level and it does the right thing. (or if it doesn't I'd appreciate a patch to make it do the right thing) Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-11 9:41 ` Ian Campbell @ 2014-02-11 9:56 ` Roger Pau Monné 2014-02-11 10:00 ` Ian Campbell 0 siblings, 1 reply; 23+ messages in thread From: Roger Pau Monné @ 2014-02-11 9:56 UTC (permalink / raw) To: Ian Campbell, Don Slutz Cc: Andrew Cooper, Stefano Stabellini, Ian Jackson, Rob Hoes, xen-devel On 11/02/14 10:41, Ian Campbell wrote: > On Mon, 2014-02-10 at 18:53 -0500, Don Slutz wrote: >> On 02/10/14 14:33, Roger Pau Monné wrote: >>> Did you run aclocal before autoconf? > >> That did what was needed. > > For future reference you can just run ./autogen.sh at the top level and > it does the right thing. > > (or if it doesn't I'd appreciate a patch to make it do the right thing) I think we have two options here if we want to add the check version stuff, either we run aclocal before autoconf (and require the user to have the autoconf-archive package) or we pick the AX_COMPARE_VERSION macro source [0] and add it to our local m4/ folder. [0] http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-11 9:56 ` Roger Pau Monné @ 2014-02-11 10:00 ` Ian Campbell 2014-02-11 10:12 ` Roger Pau Monné 0 siblings, 1 reply; 23+ messages in thread From: Ian Campbell @ 2014-02-11 10:00 UTC (permalink / raw) To: Roger Pau Monné Cc: Stefano Stabellini, Andrew Cooper, Ian Jackson, Rob Hoes, Don Slutz, xen-devel On Tue, 2014-02-11 at 10:56 +0100, Roger Pau Monné wrote: > On 11/02/14 10:41, Ian Campbell wrote: > > On Mon, 2014-02-10 at 18:53 -0500, Don Slutz wrote: > >> On 02/10/14 14:33, Roger Pau Monné wrote: > >>> Did you run aclocal before autoconf? > > > >> That did what was needed. > > > > For future reference you can just run ./autogen.sh at the top level and > > it does the right thing. > > > > (or if it doesn't I'd appreciate a patch to make it do the right thing) > > I think we have two options here if we want to add the check version > stuff, either we run aclocal before autoconf (and require the user to > have the autoconf-archive package) or we pick the AX_COMPARE_VERSION > macro source [0] and add it to our local m4/ folder. Is it the case that we currently do the latter for al the existing checks? > > [0] > http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_compare_version.m4 > > Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-11 10:00 ` Ian Campbell @ 2014-02-11 10:12 ` Roger Pau Monné 2014-02-11 10:14 ` Ian Campbell 0 siblings, 1 reply; 23+ messages in thread From: Roger Pau Monné @ 2014-02-11 10:12 UTC (permalink / raw) To: Ian Campbell Cc: Stefano Stabellini, Andrew Cooper, Ian Jackson, Rob Hoes, Don Slutz, xen-devel On 11/02/14 11:00, Ian Campbell wrote: > On Tue, 2014-02-11 at 10:56 +0100, Roger Pau Monné wrote: >> On 11/02/14 10:41, Ian Campbell wrote: >>> On Mon, 2014-02-10 at 18:53 -0500, Don Slutz wrote: >>>> On 02/10/14 14:33, Roger Pau Monné wrote: >>>>> Did you run aclocal before autoconf? >>> >>>> That did what was needed. >>> >>> For future reference you can just run ./autogen.sh at the top level and >>> it does the right thing. >>> >>> (or if it doesn't I'd appreciate a patch to make it do the right thing) >> >> I think we have two options here if we want to add the check version >> stuff, either we run aclocal before autoconf (and require the user to >> have the autoconf-archive package) or we pick the AX_COMPARE_VERSION >> macro source [0] and add it to our local m4/ folder. > > Is it the case that we currently do the latter for al the existing > checks? Yes, but I'm not sure if any of the macros we have inside of m4/ are also part of autoconf-archive (at least some of those are custom-made AFAIK). I also think it's best to do the latter, I'm going to add the macro itself to my patch and resend. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-11 10:12 ` Roger Pau Monné @ 2014-02-11 10:14 ` Ian Campbell 2014-02-11 16:31 ` Ian Jackson 0 siblings, 1 reply; 23+ messages in thread From: Ian Campbell @ 2014-02-11 10:14 UTC (permalink / raw) To: Roger Pau Monné Cc: Stefano Stabellini, Andrew Cooper, Ian Jackson, Rob Hoes, Don Slutz, xen-devel On Tue, 2014-02-11 at 11:12 +0100, Roger Pau Monné wrote: > On 11/02/14 11:00, Ian Campbell wrote: > > On Tue, 2014-02-11 at 10:56 +0100, Roger Pau Monné wrote: > >> On 11/02/14 10:41, Ian Campbell wrote: > >>> On Mon, 2014-02-10 at 18:53 -0500, Don Slutz wrote: > >>>> On 02/10/14 14:33, Roger Pau Monné wrote: > >>>>> Did you run aclocal before autoconf? > >>> > >>>> That did what was needed. > >>> > >>> For future reference you can just run ./autogen.sh at the top level and > >>> it does the right thing. > >>> > >>> (or if it doesn't I'd appreciate a patch to make it do the right thing) > >> > >> I think we have two options here if we want to add the check version > >> stuff, either we run aclocal before autoconf (and require the user to > >> have the autoconf-archive package) or we pick the AX_COMPARE_VERSION > >> macro source [0] and add it to our local m4/ folder. > > > > Is it the case that we currently do the latter for al the existing > > checks? > > Yes, but I'm not sure if any of the macros we have inside of m4/ are > also part of autoconf-archive (at least some of those are custom-made > AFAIK). I also think it's best to do the latter, I'm going to add the > macro itself to my patch and resend. Right, I think that is best for now. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-11 10:14 ` Ian Campbell @ 2014-02-11 16:31 ` Ian Jackson 0 siblings, 0 replies; 23+ messages in thread From: Ian Jackson @ 2014-02-11 16:31 UTC (permalink / raw) To: Ian Campbell Cc: Stefano Stabellini, Andrew Cooper, Rob Hoes, Don Slutz, xen-devel, Roger Pau Monné Ian Campbell writes ("Re: [Xen-devel] 4.4.0-rc3 tagged"): > On Tue, 2014-02-11 at 11:12 +0100, Roger Pau Monné wrote: > > Yes, but I'm not sure if any of the macros we have inside of m4/ are > > also part of autoconf-archive (at least some of those are custom-made > > AFAIK). I also think it's best to do the latter, I'm going to add the > > macro itself to my patch and resend. > > Right, I think that is best for now. Definitely we should copy it into our own source code. Relying on what is effectively source code in another package is pretty bad I think. Ian. ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-02-10 10:59 ` Roger Pau Monné 2014-02-10 18:48 ` Don Slutz @ 2014-03-12 13:54 ` Ian Campbell 2014-03-12 13:56 ` Ian Campbell 1 sibling, 1 reply; 23+ messages in thread From: Ian Campbell @ 2014-03-12 13:54 UTC (permalink / raw) To: Roger Pau Monné Cc: Stefano Stabellini, Andrew Cooper, Ian Jackson, Rob Hoes, Don Slutz, xen-devel On Mon, 2014-02-10 at 11:59 +0100, Roger Pau Monné wrote: > The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. > Here is an untested patch for our configure script to check for the > minimum required OCaml version (3.09.3): Did you ever get round to testing this? I also wonder if we should be testing for the first version we support, rather than the last version we didn't. Maybe that's splitting hairs a bit though. > > (remember to re-generate the configure script after applying) > > --- > commit e49609cc7b93c2633cf5a49206cb29d6bdd612be > Author: Roger Pau Monne <roger.pau@citrix.com> > Date: Mon Feb 10 11:54:13 2014 +0100 > > tools: check OCaml version is at least 3.09.3 > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > diff --git a/tools/configure.ac b/tools/configure.ac > index 0754f0e..6d1e2ee 100644 > --- a/tools/configure.ac > +++ b/tools/configure.ac > @@ -161,6 +161,12 @@ AS_IF([test "x$ocamltools" = "xy"], [ > AS_IF([test "x$enable_ocamltools" = "xyes"], [ > AC_MSG_ERROR([Ocaml tools enabled, but unable to find Ocaml])]) > ocamltools="n" > + ], [ > + AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [3.09.4], [ > + AS_IF([test "x$enable_ocamltools" = "xyes"], [ > + AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not supported])]) > + ocamltools="n" > + ]) > ]) > ]) > AS_IF([test "x$xsmpolicy" = "xy"], [ > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: 4.4.0-rc3 tagged 2014-03-12 13:54 ` Ian Campbell @ 2014-03-12 13:56 ` Ian Campbell 0 siblings, 0 replies; 23+ messages in thread From: Ian Campbell @ 2014-03-12 13:56 UTC (permalink / raw) To: Roger Pau Monné Cc: Stefano Stabellini, Andrew Cooper, Ian Jackson, Rob Hoes, Don Slutz, xen-devel On Wed, 2014-03-12 at 13:54 +0000, Ian Campbell wrote: > On Mon, 2014-02-10 at 11:59 +0100, Roger Pau Monné wrote: > > The Ocaml autoconf stuff was picked from http://forge.ocamlcore.org/. > > Here is an untested patch for our configure script to check for the > > minimum required OCaml version (3.09.3): > > Did you ever get round to testing this? Please ignore -- just saw v2 further down my mailbox... _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2014-03-12 13:56 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-31 12:14 4.4.0-rc3 tagged Ian Jackson 2014-01-31 23:07 ` Don Slutz 2014-02-03 11:48 ` Ian Jackson 2014-02-03 12:01 ` Stefano Stabellini 2014-02-07 0:15 ` Don Slutz 2014-02-07 10:05 ` Ian Campbell 2014-02-07 16:22 ` Don Slutz 2014-02-07 16:29 ` Andrew Cooper 2014-02-10 9:55 ` Ian Campbell 2014-02-10 10:59 ` Roger Pau Monné 2014-02-10 18:48 ` Don Slutz 2014-02-10 18:59 ` Roger Pau Monné 2014-02-10 19:23 ` Don Slutz 2014-02-10 19:33 ` Roger Pau Monné 2014-02-10 23:53 ` Don Slutz 2014-02-11 9:41 ` Ian Campbell 2014-02-11 9:56 ` Roger Pau Monné 2014-02-11 10:00 ` Ian Campbell 2014-02-11 10:12 ` Roger Pau Monné 2014-02-11 10:14 ` Ian Campbell 2014-02-11 16:31 ` Ian Jackson 2014-03-12 13:54 ` Ian Campbell 2014-03-12 13:56 ` Ian Campbell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).