xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Tim Deegan <tim@xen.org>
Cc: xen-devel@lists.xenproject.org, keir@xen.org,
	Ian.Jackson@eu.citrix.com, ian.campbell@citrix.com
Subject: Re: [PATCH] xen: Don't use -nostdinc flags with CLANG
Date: Tue, 11 Feb 2014 13:20:52 +0000	[thread overview]
Message-ID: <52FA23B4.5060203@linaro.org> (raw)
In-Reply-To: <20140211125928.GE97288@deinos.phlegethon.org>



On 11/02/14 12:59, Tim Deegan wrote:
> Are you using a very old version of clang?  As 06a9c7e points out,
> our current runes didn't work before clang v3.0.

I'm using clang 3.5 (which have other issue to compile Xen), but I have 
also tried 3.0 and 3.3.

> If not, rather than chasing this around any further, I think we should
> abandon trying to use the compiler-provided headers even on linux.
> Does this patch fix your build issue?
>
> commit e7003f174e0df9192dde6fa8d33b0a20f99ce053
> Author: Tim Deegan <tim@xen.org>
> Date:   Tue Feb 11 12:44:09 2014 +0000
>
>      xen: stop trying to use the system <stdarg.h> and <stdbool.h>

With this patch, -iwithprefix include is not necessary now. I wondering 
if we can remove it from the command line.

>      We already have our own versions of the stdarg/stdbool definitions, for
>      systems where those headers are installed in /usr/include.
>
>      On linux, they're typically installed in compiler-specific paths, but
>      finding them has proved unreliable.  Drop that and use our own versions
>      everywhere.
>
>      Signed-off-by: Tim Deegan <tim@xen.org>

This patch is working fine to build xen clang 3.0, 3.3.
I have others issue to build with clang 3.5.

Tested-by: Julien Grall <julien.grall@linaro.org>

Thanks!

-- 
Julien Grall

  reply	other threads:[~2014-02-11 13:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 23:29 [PATCH] xen: Don't use -nostdinc flags with CLANG Julien Grall
2014-02-11  8:37 ` Jan Beulich
2014-02-11  8:53 ` Tim Deegan
2014-02-11 12:30   ` Julien Grall
2014-02-11 12:35     ` Tim Deegan
2014-02-11 12:36       ` Julien Grall
2014-02-11 12:59         ` Tim Deegan
2014-02-11 13:20           ` Julien Grall [this message]
2014-02-11 13:59             ` Tim Deegan
2014-02-11 14:24               ` Julien Grall
2014-02-11 14:33                 ` Tim Deegan
2014-02-11 15:01                   ` Keir Fraser
2014-02-13 11:24                   ` Tim Deegan
2014-02-13 11:46                     ` George Dunlap
2014-02-13 11:49                       ` George Dunlap
2014-02-13 15:19                   ` [PATCH] xen: Don't use __builtin_stdarg_start() Tim Deegan
2014-02-13 15:22                     ` George Dunlap
2014-02-13 15:32                     ` Roger Pau Monné
2014-02-11 13:21           ` [PATCH] xen: Don't use -nostdinc flags with CLANG Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FA23B4.5060203@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).