From: David Vrabel <david.vrabel@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
mrushton@amazon.com, msw@amazon.com, boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation.
Date: Tue, 11 Feb 2014 18:21:56 +0000 [thread overview]
Message-ID: <52FA6A44.6050003@citrix.com> (raw)
In-Reply-To: <52FA68AE.6070608@citrix.com>
On 11/02/14 18:15, Roger Pau Monné wrote:
> On 11/02/14 18:52, David Vrabel wrote:
>>
> That would mean that unmap_purged_grants would no longer be static and
> I should also add a prototype for it in blkback/common.h, which is kind
> of ugly IMHO.
But less ugly than initializing work with a NULL function, IMO.
> commit 980e72e45454b64ccb7f23b6794a769384e51038
> Author: Roger Pau Monne <roger.pau@citrix.com>
> Date: Tue Feb 11 19:04:06 2014 +0100
>
> xen-blkback: init persistent_purge_work work_struct
>
> Initialize persistent_purge_work work_struct on xen_blkif_alloc (and
> remove the previous initialization done in purge_persistent_gnt). This
> prevents flush_work from complaining even if purge_persistent_gnt has
> not been used.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
Thanks.
David
next prev parent reply other threads:[~2014-02-11 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 18:44 [GIT PULL] (xen) stable/for-jens-3.14 Konrad Rzeszutek Wilk
2014-02-10 19:54 ` Jens Axboe
2014-02-11 15:52 ` [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation Sander Eikelenboom
2014-02-11 15:56 ` Konrad Rzeszutek Wilk
2014-02-11 16:07 ` Sander Eikelenboom
2014-02-11 17:40 ` Roger Pau Monné
2014-02-11 17:52 ` David Vrabel
2014-02-11 18:15 ` Roger Pau Monné
2014-02-11 18:21 ` David Vrabel [this message]
2014-02-11 20:21 ` Sander Eikelenboom
2014-02-11 21:44 ` [Xen-devel] " Jens Axboe
2014-02-12 3:14 ` Konrad Rzeszutek Wilk
2014-02-12 3:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FA6A44.6050003@citrix.com \
--to=david.vrabel@citrix.com \
--cc=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=mrushton@amazon.com \
--cc=msw@amazon.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).