From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation. Date: Tue, 11 Feb 2014 18:21:56 +0000 Message-ID: <52FA6A44.6050003@citrix.com> References: <20140210184412.GA18198@phenom.dumpdata.com> <20140210195402.GA3924@kernel.dk> <771950784.20140211165215@eikelenboom.it> <20140211155650.GA23026@phenom.dumpdata.com> <1542261541.20140211170750@eikelenboom.it> <52FA6072.40908@citrix.com> <52FA6352.1010403@citrix.com> <52FA68AE.6070608@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <52FA68AE.6070608@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Cc: Sander Eikelenboom , Konrad Rzeszutek Wilk , Jens Axboe , xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, mrushton@amazon.com, msw@amazon.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 11/02/14 18:15, Roger Pau Monn=E9 wrote: > On 11/02/14 18:52, David Vrabel wrote: >>=20 > That would mean that unmap_purged_grants would no longer be static an= d=20 > I should also add a prototype for it in blkback/common.h, which is ki= nd=20 > of ugly IMHO. But less ugly than initializing work with a NULL function, IMO. > commit 980e72e45454b64ccb7f23b6794a769384e51038 > Author: Roger Pau Monne > Date: Tue Feb 11 19:04:06 2014 +0100 >=20 > xen-blkback: init persistent_purge_work work_struct > =20 > Initialize persistent_purge_work work_struct on xen_blkif_alloc (= and > remove the previous initialization done in purge_persistent_gnt).= This > prevents flush_work from complaining even if purge_persistent_gnt= has > not been used. > =20 > Signed-off-by: Roger Pau Monn=E9 Reviewed-by: David Vrabel Thanks. David