From: David Vrabel <david.vrabel@citrix.com>
To: Mukesh Rathor <mukesh.rathor@oracle.com>
Cc: Jan Beulich <JBeulich@suse.com>,
"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Julien Grall <julien.grall@linaro.org>
Subject: Re: Error ignored in xc_map_foreign_pages
Date: Thu, 13 Feb 2014 11:03:24 +0000 [thread overview]
Message-ID: <52FCA67C.4070801@citrix.com> (raw)
In-Reply-To: <20140212185352.4c920a54@mantra.us.oracle.com>
On 13/02/14 02:53, Mukesh Rathor wrote:
> It appears that xc_map_foreign_pages() handles return incorrectly :
>
> res = xc_map_foreign_bulk(xch, dom, prot, arr, err, num);
> if (res) {
> for (i = 0; i < num; i++) {
> if (err[i]) {
> errno = -err[i];
> munmap(res, num * PAGE_SIZE);
> res = NULL;
> break;
> }
> }
> }
This looks correct to me.
Which kernel are you using?
David
prev parent reply other threads:[~2014-02-13 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 2:53 Error ignored in xc_map_foreign_pages Mukesh Rathor
2014-02-13 9:57 ` Jan Beulich
2014-02-13 10:00 ` Ian Campbell
2014-02-13 13:53 ` Andres Lagar-Cavilla
2014-02-13 11:03 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FCA67C.4070801@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=Xen-devel@lists.xensource.com \
--cc=julien.grall@linaro.org \
--cc=mukesh.rathor@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).